Page MenuHomePhabricator
Differential D9167

[lib] Introduce new avatar type for encrypted images
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 3:28 PM.
Tags
None
Referenced Files
F3754572: D9167.diff
Fri, Jan 10, 3:30 AM
Unknown Object (File)
Wed, Dec 25, 8:39 AM
Unknown Object (File)
Wed, Dec 25, 5:12 AM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMddd1344eca72: [lib] Introduce new avatar type for encrypted images
Summary

This diff introduces new avatar type for blob uploads.
Existing codebase is updated to use this type in the next diff.

Test Plan

Tested later in the stack. CI (Flow) fails until next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 12 2023, 3:28 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 3:28 PM
Harbormaster failed remote builds in B22560: Diff 31009!Sep 12 2023, 3:43 PM
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 7:57 AM
• patryk edited the test plan for this revision. (Show Details)
bartek commandeered this revision.Oct 27 2023, 10:14 AM
bartek edited reviewers, added: • patryk; removed: bartek.
bartek updated this revision to Diff 32469.Oct 27 2023, 10:17 AM

Rebase and some rework

bartek added a child revision: D9624: [web] Display encrypted image avatars.Oct 27 2023, 10:19 AM
Harbormaster failed remote builds in B23544: Diff 32469!Oct 27 2023, 10:32 AM
bartek removed a child revision: D9624: [web] Display encrypted image avatars.Oct 30 2023, 3:07 AM
bartek added a child revision: D9168: [keyserver][lib] Support new avatar type for encrypted images.
bartek updated this revision to Diff 32479.Oct 30 2023, 3:15 AM

Fix broken rebase

bartek edited the summary of this revision. (Show Details)Oct 30 2023, 3:24 AM
bartek edited the test plan for this revision. (Show Details)
Harbormaster failed remote builds in B23552: Diff 32479!Oct 30 2023, 3:26 AM
bartek edited reviewers, added: ginsu; removed: • patryk.Oct 30 2023, 3:27 AM
bartek published this revision for review.Oct 30 2023, 4:34 AM
ashoat added inline comments.Oct 30 2023, 6:10 AM
lib/types/avatar-types.js
28 ↗(On Diff #32479)

Nit: should we use underscores to match the style with your previously introduced encrypted_photo?

ginsu accepted this revision.Nov 1 2023, 11:19 AM

Looks good, but please make sure to address @ashoat's inline comment + rebase and make sure the CI passes before landing

This revision is now accepted and ready to land.Nov 1 2023, 11:19 AM
bartek added a comment.Nov 6 2023, 3:59 AM
In D9167#282846, @ginsu wrote:

rebase and make sure the CI passes before landing

This is intended to fail:

Tested later in the stack. CI (Flow) fails until next diff

lib/types/avatar-types.js
28 ↗(On Diff #32479)

makes sense

bartek updated this revision to Diff 32740.Nov 6 2023, 4:23 AM

Rebase on latest master. Replace encrypted-image with encrypted_image.

Harbormaster failed remote builds in B23778: Diff 32740!Nov 6 2023, 4:35 AM
bartek updated this revision to Diff 32861.Nov 7 2023, 5:38 AM

Rebase on latest master

Harbormaster failed remote builds in B23843: Diff 32861!Nov 7 2023, 5:49 AM
This revision was landed with ongoing or failed builds.Nov 9 2023, 11:08 PM
Closed by commit rCOMMddd1344eca72: [lib] Introduce new avatar type for encrypted images (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMddd1344eca72: [lib] Introduce new avatar type for encrypted images.

Revision Contents
Changeset List

PathSize
lib/
types/
19 lines

Diff 33046

View Options

lib/types/avatar-types.js

Loading...