Added possibility to display encrypted image avatars on web.
Details
Details
- Reviewers
ginsu atul - Commits
- rCOMMa7af2c5424d3: [web] Display encrypted image avatars
Requires some further diffs to be able to upload encrypted avatar to blob service.
Opened edit screen on web and selected new avatar. Confirmed it displays in the settings page as well as on the chat list and in the chat.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/package.json | ||
|---|---|---|
| 109 ↗ | (On Diff #32487) | The Avatar component is used in some Jest unit tests and since it's now using components with thumbhash support, it failed because that module wasn't transpiled correctly |
| web/media/encrypted-multimedia.react.js | ||
|---|---|---|
| 87 ↗ | (On Diff #32487) | Nit: Not sure if this counts as "ternary in JSX," but would be good to skim https://www.notion.so/commapp/Use-ternary-conditionals-sparingly-f4ba44a10259403592a1d15440a9847e and see if this "complies" with team style |
| web/package.json | ||
| 109 ↗ | (On Diff #32487) | Thanks for explaining |
| web/media/encrypted-multimedia.react.js | ||
|---|---|---|
| 87 ↗ | (On Diff #32487) | Technically, it complies:
It's arguable, but tried the if-else too and it doesn't look much better if (!source && !invisibleLoad) { if (props.loadingIndicatorComponent) { loadingIndicator = props.loadingIndicatorComponent } else { loadingIndicator = ( <LoadingIndicator status="loading" size="large" color="white" loadingClassName={css.loadingIndicator} /> ); } } |