Details

Reviewers

atul
ginsu

Commits

rCOMMccdc1335b3f9: [web] Support avatar uploads to blob service

Summary

This diff enables avatar uploads to blob service on web. Modified the hook to conditionally use function that uploads avatar to blob service instead of keyserver. This is very similar to what we currently do with multimedia messages.

Test Plan

Tested on both user and thread avatars.
With the flag set to true, changed the avatar to an image and used TablePlus to verify MariaDB contents (this tests changes to D9168). Also, the avatar was then displayed correctly (which is more deeply tested in D9624)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 12 2023, 3:30 PM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 3:30 PM

Harbormaster failed remote builds in B22563: Diff 31012!Sep 12 2023, 3:46 PM

• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 8:00 AM

• patryk edited the test plan for this revision. (Show Details)

bartek commandeered this revision.Oct 27 2023, 10:15 AM

bartek edited reviewers, added: • patryk; removed: bartek.

Rebase and some rework

bartek added a parent revision: D9169: [lib] Add blob service upload avatar type validators.Oct 27 2023, 10:20 AM

Harbormaster failed remote builds in B23548: Diff 32473!Oct 27 2023, 10:36 AM

Fix broken rebase

bartek mentioned this in D9168: [keyserver][lib] Support new avatar type for encrypted images.Oct 30 2023, 3:26 AM

bartek mentioned this in D9169: [lib] Add blob service upload avatar type validators.Oct 30 2023, 3:29 AM

bartek edited the summary of this revision. (Show Details)Oct 30 2023, 3:32 AM

bartek edited the test plan for this revision. (Show Details)

bartek edited reviewers, added: ginsu; removed: • patryk.

Harbormaster failed remote builds in B23556: Diff 32483!Oct 30 2023, 3:37 AM

Rebase on fix

bartek published this revision for review.Oct 30 2023, 5:21 AM

Harbormaster completed remote builds in B23561: Diff 32488.Oct 30 2023, 5:48 AM

Set the flag gate to false

bartek edited parent revisions, added: D9624: [web] Display encrypted image avatars; removed: D9169: [lib] Add blob service upload avatar type validators.Nov 1 2023, 1:02 AM

bartek added a child revision: D9668: [native] Support displaying encrypted avatars.Nov 1 2023, 1:04 AM

bartek mentioned this in D9669: [native] Support avatar uploads to blob service.Nov 1 2023, 1:07 AM

Harbormaster completed remote builds in B23639: Diff 32587.Nov 1 2023, 1:23 AM

atul accepted this revision.Nov 1 2023, 7:19 PM

This revision is now accepted and ready to land.Nov 1 2023, 7:19 PM

Rebase

Harbormaster completed remote builds in B23782: Diff 32744.Nov 6 2023, 5:16 AM

Rebase on multi-keyserver action update

bartek added a parent revision: D9738: [lib] Accept keyserver ID in blob service upload action.Nov 7 2023, 12:15 AM

Harbormaster failed remote builds in B23826: Diff 32842!Nov 7 2023, 12:31 AM

ashoat added inline comments.Nov 7 2023, 3:24 AM

web/avatars/edit-user-avatar-menu.react.js
74 ↗	(On Diff #32842)	Comment above the definition of `baseSetUserAvatar` says: // NOTE: Do NOT consume `baseSetUserAvatar` directly. // Use platform-specific `[web/native]SetUserAvatar` instead. Are we sure this is okay? If we're sure it's okay, should we change the comment?

bartek added inline comments.Nov 7 2023, 3:34 AM

web/avatars/edit-user-avatar-menu.react.js
74 ↗	(On Diff #32842)	I don't have much context on this, It was done this way before my diff. There is `nativeSetUserAvatar()` but there is no `webSetUserAvatar()`. cc @atul who introduced this in D8344