Details

Reviewers

ginsu
atul

Commits

rCOMMa7af2c5424d3: [web] Display encrypted image avatars

Summary

Added possibility to display encrypted image avatars on web.

Test Plan

Requires some further diffs to be able to upload encrypted avatar to blob service.
Opened edit screen on web and selected new avatar. Confirmed it displays in the settings page as well as on the chat list and in the chat.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 27 2023, 10:19 AM

bartek held this revision as a draft.

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 27 2023, 10:19 AM

bartek added a child revision: D9168: [keyserver][lib] Support new avatar type for encrypted images.Oct 27 2023, 10:19 AM

Harbormaster failed remote builds in B23545: Diff 32470!Oct 27 2023, 10:34 AM

bartek removed a parent revision: D9167: [lib] Introduce new avatar type for encrypted images.Oct 30 2023, 3:07 AM

bartek removed a child revision: D9168: [keyserver][lib] Support new avatar type for encrypted images.

bartek edited the summary of this revision. (Show Details)

bartek added a parent revision: D9169: [lib] Add blob service upload avatar type validators.Oct 30 2023, 3:10 AM

Fix broken rebase

bartek mentioned this in D9168: [keyserver][lib] Support new avatar type for encrypted images.Oct 30 2023, 3:28 AM

bartek mentioned this in D9170: [web] Support avatar uploads to blob service.Oct 30 2023, 3:32 AM

Harbormaster failed remote builds in B23555: Diff 32482!Oct 30 2023, 3:33 AM

Fix jest and babel being too dumb to understand imports syntax in thumbhash module

bartek published this revision for review.Oct 30 2023, 5:21 AM

bartek added inline comments.

web/package.json
109	The `Avatar` component is used in some Jest unit tests and since it's now using components with thumbhash support, it failed because that module wasn't transpiled correctly

Harbormaster completed remote builds in B23560: Diff 32487.Oct 30 2023, 5:32 AM

bartek added a child revision: D9170: [web] Support avatar uploads to blob service.Nov 1 2023, 1:02 AM

bartek mentioned this in D9669: [native] Support avatar uploads to blob service.Nov 1 2023, 1:07 AM

atul accepted this revision.Nov 1 2023, 7:22 PM

atul added inline comments.

web/media/encrypted-multimedia.react.js
87	Nit: Not sure if this counts as "ternary in JSX," but would be good to skim https://www.notion.so/commapp/Use-ternary-conditionals-sparingly-f4ba44a10259403592a1d15440a9847e and see if this "complies" with team style
web/package.json
109	Thanks for explaining

ginsu accepted this revision.Nov 2 2023, 10:25 AM

This revision is now accepted and ready to land.Nov 2 2023, 10:25 AM

bartek added inline comments.Nov 6 2023, 3:57 AM

web/media/encrypted-multimedia.react.js

Technically, it complies:

it's not nested
it's not inside JSX, but rather wraps it
formatting is clear to me

It's arguable, but tried the if-else too and it doesn't look much better

if (!source && !invisibleLoad) {
  if (props.loadingIndicatorComponent) {
    loadingIndicator = props.loadingIndicatorComponent
  } else {
    loadingIndicator = (
      <LoadingIndicator
        status="loading"
        size="large"
        color="white"
        loadingClassName={css.loadingIndicator}
      />
    );
  }
}