[CommCoreModule] capture primitive parameter by value
ClosedPublic
Actions

Authored by kamil on Sep 14 2023, 1:10 AM.

Details

Reviewers

michal
bartek
marcin
tomek

Commits

rCOMM798e3599316a: [CommCoreModule] capture primitive parameter by value

Summary

Fixes regression introduced in D8887.

This is a solution for ENG-4926.

When the code gets to run, the outer function generateRandomString may have already returned. This means that size might have been destroyed, and there is an undefined reference. That's why this function generates backupID with length 0 and as an effect causes Argon2 to throw salt too short.

On dev everything worked, everything happens only on prod when code is more optimized.

I also added casting to the correct type.

Test Plan

Test upload protocol in Release mode.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 14 2023, 1:10 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 1:10 AM

kamil edited the summary of this revision. (Show Details)Sep 14 2023, 1:11 AM

kamil published this revision for review.Sep 14 2023, 1:20 AM

Harbormaster completed remote builds in B22623: Diff 31119.Sep 14 2023, 1:28 AM

bartek accepted this revision.Sep 14 2023, 3:41 AM

This revision is now accepted and ready to land.Sep 14 2023, 3:41 AM

Closed by commit rCOMM798e3599316a: [CommCoreModule] capture primitive parameter by value (authored by kamil). · Explain WhySep 14 2023, 5:19 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM798e3599316a: [CommCoreModule] capture primitive parameter by value.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

8 lines

Diff 31128

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

	// @flow			// @flow

				import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
	import * as React from 'react';			import * as React from 'react';

	import { type ThreadInfo } from 'lib/types/thread-types';			import { type ThreadInfo } from 'lib/types/thread-types';

	import SWMansionIcon from '../SWMansionIcon.react';			import SWMansionIcon from '../SWMansionIcon.react';
				import ThreadMenuItem from './thread-menu-item.react';
	import css from './thread-menu.css';			import css from './thread-menu.css';

	type ThreadMenuProps = {			type ThreadMenuProps = {
	+threadInfo: ThreadInfo,			+threadInfo: ThreadInfo,
	};			};

	function ThreadMenu(props: ThreadMenuProps): React.Node {			function ThreadMenu(props: ThreadMenuProps): React.Node {
	const [isOpen, setIsOpen] = React.useState(false);			const [isOpen, setIsOpen] = React.useState(false);

	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	const { threadInfo } = props;			const { threadInfo } = props;

	const menuItems = [];			const menuItems = React.useMemo(() => {
				const settingsItem = (
				<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
				);
				const notificationsItem = (
				<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
				);
				const items = [settingsItem, notificationsItem];
				return items.filter(Boolean);
				}, []);

	const closeMenuCallback = React.useCallback(() => {			const closeMenuCallback = React.useCallback(() => {
	document.removeEventListener('click', closeMenuCallback);			document.removeEventListener('click', closeMenuCallback);
	if (isOpen) {			if (isOpen) {
	setIsOpen(false);			setIsOpen(false);
	}			}
	}, [isOpen]);			}, [isOpen]);

	Show All 34 Lines

[CommCoreModule] capture primitive parameter by valueClosedPublicActions