Page MenuHomePhabricator

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic

Authored by atul on Sep 14 2023, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:07 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Sun, Oct 27, 12:50 AM
Unknown Object (File)
Oct 12 2024, 6:44 AM
Unknown Object (File)
Oct 7 2024, 11:29 AM
Unknown Object (File)
Oct 5 2024, 7:59 PM
Unknown Object (File)
Oct 1 2024, 9:50 PM
Unknown Object (File)
Oct 1 2024, 9:05 PM
Subscribers

Details

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.


Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable