Paths

Table of Contentst

Differential D9213

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic
Actions

Authored by atul on Thu, Sep 14, 7:33 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM3df742db5cd1: [native] Memoize `ThreadAncestorsLabel`

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.

Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Thu, Sep 14, 7:33 PM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Sep 14, 7:33 PM

atul published this revision for review.Thu, Sep 14, 7:44 PM

atul added a child revision: D9214: [native] Memoize `ConnectedRemoteImage`.Thu, Sep 14, 7:44 PM

Harbormaster completed remote builds in B22648: Diff 31159.Thu, Sep 14, 7:50 PM

rohan accepted this revision.Fri, Sep 15, 2:13 PM

This revision is now accepted and ready to land.Fri, Sep 15, 2:13 PM

rebase and land

This revision was landed with ongoing or failed builds.Sun, Sep 17, 3:31 PM

Closed by commit rCOMM3df742db5cd1: [native] Memoize `ThreadAncestorsLabel` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3df742db5cd1: [native] Memoize `ThreadAncestorsLabel`.

Harbormaster completed remote builds in B22667: Diff 31185.Sun, Sep 17, 3:46 PM

Revision Contents
Changeset List

Path

Size

native/

components/

thread-ancestors-label.react.js

13 lines

Diff 31188

native/components/thread-ancestors-label.react.js

Loading...