Page MenuHomePhabricator

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic

Authored by atul on Sep 14 2023, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 18, 3:26 AM
Unknown Object (File)
Sun, Apr 28, 1:32 PM
Unknown Object (File)
Sun, Apr 28, 1:32 PM
Unknown Object (File)
Sun, Apr 28, 1:31 PM
Unknown Object (File)
Sun, Apr 28, 1:30 PM
Unknown Object (File)
Sun, Apr 28, 1:10 PM
Unknown Object (File)
Apr 16 2024, 1:34 PM
Unknown Object (File)
Apr 15 2024, 12:11 AM
Subscribers

Details

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.


Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable