Page MenuHomePhabricator

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic

Authored by atul on Sep 14 2023, 7:33 PM.
Tags
None
Referenced Files
F3537776: D9213.diff
Wed, Dec 25, 10:14 PM
Unknown Object (File)
Thu, Nov 28, 3:57 AM
Unknown Object (File)
Thu, Nov 28, 1:20 AM
Unknown Object (File)
Nov 24 2024, 9:29 AM
Unknown Object (File)
Nov 24 2024, 9:29 AM
Unknown Object (File)
Nov 20 2024, 8:07 AM
Unknown Object (File)
Oct 27 2024, 12:55 AM
Unknown Object (File)
Oct 27 2024, 12:50 AM
Subscribers

Details

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.


Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable