Page MenuHomePhabricator

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic

Authored by atul on Sep 14 2023, 7:33 PM.
Tags
None
Referenced Files
F2188565: D9213.id31188.diff
Thu, Jul 4, 9:24 AM
F2186288: D9213.id.diff
Thu, Jul 4, 2:43 AM
F2185274: D9213.id31159.diff
Wed, Jul 3, 11:35 PM
Unknown Object (File)
Wed, Jul 3, 6:27 PM
Unknown Object (File)
Sat, Jun 29, 8:52 PM
Unknown Object (File)
Wed, Jun 26, 11:26 PM
Unknown Object (File)
Tue, Jun 18, 7:18 AM
Unknown Object (File)
Fri, Jun 14, 12:23 AM
Subscribers

Details

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.


Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable