Page MenuHomePhabricator

[native] Memoize `ConnectedRemoteImage`
ClosedPublic

Authored by atul on Sep 14 2023, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 3:08 PM
Unknown Object (File)
Tue, Apr 30, 8:40 AM
Unknown Object (File)
Tue, Apr 30, 1:42 AM
Unknown Object (File)
Sun, Apr 28, 1:32 PM
Unknown Object (File)
Sun, Apr 28, 1:32 PM
Unknown Object (File)
Sun, Apr 28, 1:32 PM
Unknown Object (File)
Sun, Apr 28, 1:30 PM
Unknown Object (File)
Sun, Apr 28, 1:10 PM
Subscribers

Details

Summary

Similar to D9213, the profiler isn't providing much information here so I'm memoizing this on a whim to see if anything changes. Doubt this changes anything at all.


Depends on D9213

Test Plan

ConnectedRemoteImage continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Sep 14 2023, 7:44 PM

If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?

This revision is now accepted and ready to land.Sep 15 2023, 2:21 PM
In D9214#271139, @rohan wrote:

If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?

Memory usage of these memoizations is pretty much trivial

This revision was landed with ongoing or failed builds.Sep 17 2023, 3:31 PM
This revision was automatically updated to reflect the committed changes.