[native] Memoize `ConnectedRemoteImage`
ClosedPublic
Actions

Authored by atul on Sep 14 2023, 7:44 PM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM5e8672d069eb: [native] Memoize `ConnectedRemoteImage`

Summary

Similar to D9213, the profiler isn't providing much information here so I'm memoizing this on a whim to see if anything changes. Doubt this changes anything at all.

Depends on D9213

Test Plan

ConnectedRemoteImage continues to look as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 14 2023, 7:44 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 7:44 PM

atul published this revision for review.Sep 14 2023, 7:44 PM

Harbormaster completed remote builds in B22649: Diff 31160.Sep 14 2023, 8:02 PM

atul added a child revision: D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.Sep 14 2023, 9:40 PM

If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?

This revision is now accepted and ready to land.Sep 15 2023, 2:21 PM

In D9214#271139, @rohan wrote:

If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?

Memory usage of these memoizations is pretty much trivial

rebase and land

This revision was landed with ongoing or failed builds.Sep 17 2023, 3:31 PM

Closed by commit rCOMM5e8672d069eb: [native] Memoize `ConnectedRemoteImage` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5e8672d069eb: [native] Memoize `ConnectedRemoteImage`.

Harbormaster completed remote builds in B22668: Diff 31187.Sep 17 2023, 3:47 PM