Differential D9288

[web] Use redux cookie for communication
ClosedPublic
Actions

Authored by michal on Sep 25 2023, 7:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 3, 9:23 AM

	Unknown Object (File)
	Sat, Sep 28, 7:57 PM

	Unknown Object (File)
	Sat, Sep 28, 7:57 PM

	Unknown Object (File)
	Sat, Sep 28, 7:57 PM

	Unknown Object (File)
	Sat, Sep 28, 7:55 PM

	Unknown Object (File)
	Aug 31 2024, 11:29 PM

	Unknown Object (File)
	Aug 31 2024, 4:07 AM

	Unknown Object (File)
	Aug 29 2024, 5:48 AM

View All 61 Files

Subscribers

Details

Reviewers

inka
kamil
atul

Commits

rCOMMbe010293e8be: [web] Use redux cookie for communication

Summary

ENG-4748
Depends on D9287

Actually start using the redux cookie on web.

Test Plan

Log in to incognito window:

check that there is only anonymous browser cookie (sent when loading a web page, but not replaced when logged in)
send a message
check that there are no errors in console, no errors on the keyserver
check that there is no disconnected banner (no more than usual)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 25 2023, 7:19 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 25 2023, 7:19 AM

michal added a child revision: D9290: [keyserver] Stop sending http cookies.Sep 25 2023, 7:33 AM

Harbormaster completed remote builds in B22831: Diff 31402.Sep 25 2023, 7:37 AM

michal requested review of this revision.Sep 25 2023, 7:37 AM

kamil accepted this revision.Sep 26 2023, 2:33 AM

This revision is now accepted and ready to land.Sep 26 2023, 2:33 AM

michal mentioned this in D9502: [lib] Remove setCookieOnRequest.Oct 16 2023, 5:35 AM

Closed by commit rCOMMbe010293e8be: [web] Use redux cookie for communication (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 23 2023, 3:05 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMbe010293e8be: [web] Use redux cookie for communication.

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest.

Revision Contents
Changeset List

Path

Size

lib/

socket/

socket.react.js

6 lines

web/

4 lines

selectors/

socket-selectors.js

7 lines

Diff 32310

lib/socket/socket.react.js

Loading...

web/app.react.js

Loading...

web/selectors/socket-selectors.js

Loading...