Page MenuHomePhabricator
Differential D9502

[lib] Remove setCookieOnRequest
ClosedPublic
Actions

Authored by michal on Oct 16 2023, 5:35 AM.
Tags
None
Referenced Files
F5098255: D9502.id32036.diff
Mon, Mar 31, 2:04 AM
Unknown Object (File)
Sat, Mar 15, 5:02 AM
Unknown Object (File)
Feb 25 2025, 5:08 PM
Unknown Object (File)
Feb 23 2025, 10:51 PM
Unknown Object (File)
Feb 14 2025, 4:33 PM
Unknown Object (File)
Feb 14 2025, 4:33 PM
Unknown Object (File)
Feb 14 2025, 4:32 PM
Unknown Object (File)
Feb 14 2025, 4:25 PM
View All 88 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
kamil
atul
ashoat
Commits
rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest
Summary

ENG-4747
Depends on D9290

After D9288 both web and native had this config set to true so we can remove it and simplify the code.

Test Plan

yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Oct 16 2023, 5:35 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 16 2023, 5:35 AM
Harbormaster completed remote builds in B23263: Diff 32036.Oct 16 2023, 5:53 AM
michal requested review of this revision.Oct 16 2023, 5:53 AM
atul accepted this revision.Oct 17 2023, 10:17 AM
atul added a reviewer: ashoat.

Accepting, but adding @ashoat as blocking to take another look

ashoat accepted this revision.Oct 18 2023, 1:41 PM
ashoat added inline comments.
lib/utils/call-server-endpoint.js
78–84 ↗(On Diff #32036)

Thanks for finding / deleting this comment

This revision is now accepted and ready to land.Oct 18 2023, 1:41 PM
Closed by commit rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 23 2023, 3:05 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest.

Revision Contents
Changeset List

PathSize
lib/
utils/
17 lines
1 line
10 lines
native/
1 line
web/
1 line

Diff 32311

View Options

lib/utils/call-server-endpoint.js

Show All 34 Linesconst bridge: ElectronBridge = {
}, },
onNotificationClicked: callback => { onNotificationClicked: callback => {
const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) => const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
callback(...args); callback(...args);
ipcRenderer.on('on-notification-clicked', withEvent); ipcRenderer.on('on-notification-clicked', withEvent);
return () => return () =>
ipcRenderer.removeListener('on-notification-clicked', withEvent); ipcRenderer.removeListener('on-notification-clicked', withEvent);
}, },
fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
}; };
contextBridge.exposeInMainWorld('electronContextBridge', bridge); contextBridge.exposeInMainWorld('electronContextBridge', bridge);
View Options

lib/utils/config.js

Show All 34 Linesconst bridge: ElectronBridge = {
}, },
onNotificationClicked: callback => { onNotificationClicked: callback => {
const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) => const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
callback(...args); callback(...args);
ipcRenderer.on('on-notification-clicked', withEvent); ipcRenderer.on('on-notification-clicked', withEvent);
return () => return () =>
ipcRenderer.removeListener('on-notification-clicked', withEvent); ipcRenderer.removeListener('on-notification-clicked', withEvent);
}, },
fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
}; };
contextBridge.exposeInMainWorld('electronContextBridge', bridge); contextBridge.exposeInMainWorld('electronContextBridge', bridge);
View Options

lib/utils/upload-blob.js

Show All 34 Linesconst bridge: ElectronBridge = {
}, },
onNotificationClicked: callback => { onNotificationClicked: callback => {
const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) => const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
callback(...args); callback(...args);
ipcRenderer.on('on-notification-clicked', withEvent); ipcRenderer.on('on-notification-clicked', withEvent);
return () => return () =>
ipcRenderer.removeListener('on-notification-clicked', withEvent); ipcRenderer.removeListener('on-notification-clicked', withEvent);
}, },
fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
}; };
contextBridge.exposeInMainWorld('electronContextBridge', bridge); contextBridge.exposeInMainWorld('electronContextBridge', bridge);
View Options

native/config.js

Show All 34 Linesconst bridge: ElectronBridge = {
}, },
onNotificationClicked: callback => { onNotificationClicked: callback => {
const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) => const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
callback(...args); callback(...args);
ipcRenderer.on('on-notification-clicked', withEvent); ipcRenderer.on('on-notification-clicked', withEvent);
return () => return () =>
ipcRenderer.removeListener('on-notification-clicked', withEvent); ipcRenderer.removeListener('on-notification-clicked', withEvent);
}, },
fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
}; };
contextBridge.exposeInMainWorld('electronContextBridge', bridge); contextBridge.exposeInMainWorld('electronContextBridge', bridge);
View Options

web/app.react.js

Show All 34 Linesconst bridge: ElectronBridge = {
}, },
onNotificationClicked: callback => { onNotificationClicked: callback => {
const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) => const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
callback(...args); callback(...args);
ipcRenderer.on('on-notification-clicked', withEvent); ipcRenderer.on('on-notification-clicked', withEvent);
return () => return () =>
ipcRenderer.removeListener('on-notification-clicked', withEvent); ipcRenderer.removeListener('on-notification-clicked', withEvent);
}, },
fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
}; };
contextBridge.exposeInMainWorld('electronContextBridge', bridge); contextBridge.exposeInMainWorld('electronContextBridge', bridge);