Details

Reviewers

atul
ginsu

Commits

rCOMM36fc0ddd0799: [lib] Introduce a canBeSidebarSource function in each message spec

Summary

The last part of unifying the logic and source of truth for determining eligible messages to be sidebar sources is to have a canBeSidebarSource function in each message spec. This diff introduces the constant to each existing message spec, and the next diffs will replace the logic in to isInvalidSidebarSoruce to call the message spec. This ensures that we'll only ever need to update the specific message spec in one place and the ValidRawSidebarSourceMessageInfo type if we ever want to change this.

Depends on D9324

Resolves https://linear.app/comm/issue/ENG-5208/introduce-a-canbesidebarsource-function-in-each-message-spec

Test Plan

Ran flow and updated the unit tests to call canBeSidebarSource. yarn workspace lib test passes all tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Sep 28 2023, 3:47 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 28 2023, 3:47 PM

Update unit tests to test for the new message spec function

rohan edited the test plan for this revision. (Show Details)Sep 28 2023, 3:56 PM

Harbormaster completed remote builds in B22907: Diff 31538.Sep 28 2023, 4:06 PM

Harbormaster completed remote builds in B22908: Diff 31539.Sep 28 2023, 4:13 PM

rohan requested review of this revision.Sep 28 2023, 4:13 PM

rohan added a child revision: D9330: [keyserver/lib] Update isInvalidSidebarSource to check messageSpec.canBeSidebarSource.Sep 29 2023, 8:35 AM

Update describe statement in unit tests

Harbormaster completed remote builds in B22915: Diff 31549.Sep 29 2023, 8:55 AM

Get rid of redundant logic

rohan edited the summary of this revision. (Show Details)Sep 29 2023, 12:08 PM

Harbormaster completed remote builds in B22925: Diff 31559.Sep 29 2023, 12:19 PM

looks good! Trusting test plan so skimmed through the test file

ginsu accepted this revision.Sep 29 2023, 12:46 PM

This revision is now accepted and ready to land.Sep 29 2023, 12:46 PM

This ensures that we'll only ever need to update the specific message spec in one place if we ever want to change this.

Would we also need to update the ValidRawSidebarSourceMessageInfo type introduced in D9324?

In D9325#274666, @ashoat wrote:

This ensures that we'll only ever need to update the specific message spec in one place if we ever want to change this.

Would we also need to update the ValidRawSidebarSourceMessageInfo type introduced in D9324?

Oh yeah you're right, that too if we were change one of the message specs

rohan edited the summary of this revision. (Show Details)Oct 3 2023, 9:20 AM

Rebase

Harbormaster completed remote builds in B23147: Diff 31874.Oct 10 2023, 8:20 AM

rohan edited the summary of this revision. (Show Details)Oct 10 2023, 9:00 AM

Closed by commit rCOMM36fc0ddd0799: [lib] Introduce a canBeSidebarSource function in each message spec (authored by rohan). · Explain WhyOct 20 2023, 8:27 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM36fc0ddd0799: [lib] Introduce a canBeSidebarSource function in each message spec.

[lib] Introduce a canBeSidebarSource function in each message spec
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31559

lib/shared/messages/add-members-message-spec.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/edit-message-spec.js

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/remove-members-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/sidebar-source-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/toggle-pin-message-spec.js

lib/shared/messages/unsupported-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

lib/types/message-types.test.js

[lib] Introduce a canBeSidebarSource function in each message specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31559

lib/shared/messages/add-members-message-spec.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/edit-message-spec.js

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/remove-members-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/sidebar-source-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/toggle-pin-message-spec.js

lib/shared/messages/unsupported-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

lib/types/message-types.test.js

[lib] Introduce a canBeSidebarSource function in each message spec
ClosedPublic
Actions

Revision Contents
Changeset List