Page MenuHomePhabricator

[native] introduce UserProfileBottomSheetNavigator
ClosedPublic

Authored by ginsu on Oct 5 2023, 11:54 AM.
Tags
None
Referenced Files
F3181067: D9375.diff
Fri, Nov 8, 5:26 AM
F3178044: D9375.id31711.diff
Fri, Nov 8, 12:48 AM
F3177147: D9375.id31711.diff
Thu, Nov 7, 10:40 PM
F3177047: D9375.id31707.diff
Thu, Nov 7, 10:30 PM
F3176984: D9375.id31691.diff
Thu, Nov 7, 10:15 PM
F3176763: D9375.id31692.diff
Thu, Nov 7, 9:45 PM
F3176292: D9375.id31707.diff
Thu, Nov 7, 9:03 PM
F3176261: D9375.id31691.diff
Thu, Nov 7, 8:45 PM
Subscribers

Details

Summary

In order to navigate to User Profile Avatar Modal from our user profile bottom sheet we need to introduce a new overlay navigator (this should be an overlay navigator since we want to layer the User Profile Avatar Modal on top of the User Profile Bottom sheet)

This is step 3 in the list below
Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Replace out of box BottomSheetModal with basic BottomSheet (Unfortunately, BottomSheetModal does not play nice with nested navigator)
  2. Polish up the BottomSheetBackdrop animation
  3. Introduce User Profile Bottom Sheet Navigators (this is so we can navigate to User Profile Avatar Modal from the User Profile Bottom Sheet)
  4. Introduce the User Profile Avatar Modal component and all the necessary things (like route names) that we will need to navigate to this new screen
  5. Factor out the User Avatar component in UserProfile into it's own separate component to keep things better organized

Depends on D9374

Test Plan

Confirmed that I was able to navigate to the user profile bottom sheet with this new nested navigator and I was able to navigate to the User Profile Avatar (which will be introduced in a subsequent diff)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Oct 5 2023, 12:16 PM
ginsu edited the test plan for this revision. (Show Details)

update

native/user-profile/user-profile-bottom-sheet.react.js
39 ↗(On Diff #31693)

Now that we are nesting navigators, we want to use goBack so that the parent (root) navigator will handle brining the user back to the screen they were on before opening the user profile

https://reactnavigation.org/docs/nesting-navigators/#navigation-actions-are-handled-by-current-navigator-and-bubble-up-if-couldnt-be-handled

This revision is now accepted and ready to land.Oct 5 2023, 4:20 PM

rebase one more time before landing (had a phab error when attempted to recently land)

This revision was landed with ongoing or failed builds.Oct 5 2023, 6:38 PM
This revision was automatically updated to reflect the committed changes.