Page MenuHomePhabricator
Differential D9380

[native] make UserRelationshipTooltipButton a functional component
ClosedPublic
Actions

Authored by ginsu on Oct 5 2023, 2:27 PM.
Tags
None
Referenced Files
F3178371: D9380.id31716.diff
Fri, Nov 8, 1:40 AM
F3174923: D9380.id31716.diff
Thu, Nov 7, 7:10 PM
F3171975: D9380.diff
Thu, Nov 7, 1:54 PM
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:14 AM
Unknown Object (File)
Sat, Oct 26, 1:13 AM
View All 75 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM4f201aea8ff2: [native] make UserRelationshipTooltipButton a functional component
Summary

In a subsequent diff I am going to need to use the useColors hook. I figured the easiest/best way to call that hook is going to be by first converting UserRelationshipTooltipButton into a functional component

This is step 3 in the list below
Outlined below are the steps I will take to update RelationshipListItemTooltipModal:

  1. Add the block action to relationship list item tooltip menu (RelationshipListItem won't need this option, but User profiles will. This is shown in the figma screenshot above)
  2. Rename RelationshipListItemTooltipModal to something more generic like UserRelationshipTooltipModal
  3. Make UserRelationshipTooltipButton into a functional component (We need to use the useColors hook in a subsequent diff)
  4. Introduce the tooltipButtonIcon as a param to RelationshipListItemTooltipModal (RelationshipListItem will use a pencil icon and user profiles will use a kebab menu icon)
  5. Introduce UserProfileMenuButton (This component will handle navigating to RelationshipListItemTooltipModal

Depends on D9379

Test Plan

flow and confirmed that there were no regressions with UserRelationshipTooltipModal when pressing the edit button in RelationshipListItem

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 5 2023, 2:27 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 2:27 PM
ginsu edited the summary of this revision. (Show Details)Oct 5 2023, 2:30 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9379: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal.
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B23021: Diff 31701.Oct 5 2023, 2:45 PM
ginsu requested review of this revision.Oct 5 2023, 2:45 PM
ginsu added a child revision: D9381: [native] introduce tooltipButtonIcon to UserRelationshipTooltipModalParams.Oct 5 2023, 3:34 PM
atul accepted this revision.Oct 5 2023, 4:31 PM
atul added inline comments.
native/profile/user-relationship-tooltip-modal.react.js
136–138 ↗(On Diff #31701)

Rendering SVGs can be kind of expensive. Haven't actually profiled in this case, but would be good to wrap this in useMemo

This revision is now accepted and ready to land.Oct 5 2023, 4:31 PM
ginsu added inline comments.Oct 5 2023, 6:31 PM
native/profile/user-relationship-tooltip-modal.react.js
136–138 ↗(On Diff #31701)

In D9381 (the very next diff) I pull out <PencilIcon /> and wrap it in a useMemo

ginsu updated this revision to Diff 31716.Oct 5 2023, 6:32 PM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 5 2023, 6:38 PM
Closed by commit rCOMM4f201aea8ff2: [native] make UserRelationshipTooltipButton a functional component (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4f201aea8ff2: [native] make UserRelationshipTooltipButton a functional component.
Harbormaster completed remote builds in B23036: Diff 31716.Oct 5 2023, 6:54 PM

Revision Contents
Changeset List

PathSize
native/
profile/
20 lines

Diff 31724

View Options

native/profile/user-relationship-tooltip-modal.react.js

Loading...