[keyserver] refactor functions to check rotate/forget prekeys
ClosedPublic
Actions

Authored by kamil on Oct 9 2023, 1:54 PM.

Details

Reviewers

varun
marcin
ashoat

Commits

rCOMMa19392f89fe0: [keyserver] refactor functions to check rotate/forget prekeys

Summary

Issue: ENG-3944.

This is part of D8476 (breaking this for smaller diffs because it's complex).
Addresses:

Fixes:

https://linear.app/comm/issue/ENG-5197/fix-last-prekey-publish-time-usage

Test Plan

Flow
check if time last publish time is properly retrieved

Diff Detail

Repository

rCOMM Comm

Branch

publish-prekey-rotation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 9 2023, 1:54 PM

kamil held this revision as a draft.

Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 1:54 PM

kamil added a child revision: D9420: [keyserver] implement function to get account prekey and prekey signature.Oct 9 2023, 1:58 PM

Harbormaster completed remote builds in B23094: Diff 31796.Oct 9 2023, 2:12 PM

kamil published this revision for review.Oct 9 2023, 3:18 PM

kamil added inline comments.

keyserver/src/utils/olm-utils.js
33

kamil mentioned this in D8476: [Keyserver] Publish prekeys to identity service for cron job.Oct 9 2023, 3:20 PM

marcin accepted this revision.Oct 10 2023, 2:31 PM

This revision is now accepted and ready to land.Oct 10 2023, 2:31 PM

ashoat accepted this revision.Oct 10 2023, 2:35 PM

update comment

Harbormaster completed remote builds in B23170: Diff 31901.Oct 11 2023, 9:50 AM

Closed by commit rCOMMa19392f89fe0: [keyserver] refactor functions to check rotate/forget prekeys. · Explain WhyOct 16 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa19392f89fe0: [keyserver] refactor functions to check rotate/forget prekeys.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

olm-utils.js

53 lines

Diff 31796

View Options

keyserver/src/utils/olm-utils.js

[keyserver] refactor functions to check rotate/forget prekeysClosedPublicActions