Paths

Table of Contentst

Differential D9432

[landing] Reduce code duplication in landing/siwe.react.js
ClosedPublic
Actions

Authored by ashoat on Oct 9 2023, 10:09 AM.

Tags

None

Referenced Files

	F3339743: D9432.diff
	Thu, Nov 21, 8:34 PM

	Unknown Object (File)
	Wed, Nov 20, 6:57 PM

	Unknown Object (File)
	Wed, Nov 20, 4:39 PM

	Unknown Object (File)
	Wed, Nov 20, 4:39 PM

	Unknown Object (File)
	Wed, Nov 20, 4:37 PM

	Unknown Object (File)
	Wed, Nov 20, 4:18 PM

	Unknown Object (File)
	Wed, Nov 13, 9:54 PM

	Unknown Object (File)
	Wed, Nov 13, 9:49 PM

View All 62 Files

Subscribers

Details

Reviewers

rohan
atul
ginsu

Commits

rCOMMd8339b2979f1: [landing] Reduce code duplication in landing/siwe.react.js

Summary

This code is completely duplicated from lib/utils/wagmi-utils.js.

Test Plan

In my local environment, make sure that mobile SIWE still works with Rainbow wallet (mobile SIWE uses landing, but web SIWE doesn't)
In combination with other diffs in the stack, I tested the following on both my local environment, and in a staging environment for my keyserver on comm.domains:
- Mobile sign in with Rainbow wallet using Rainbow login
- Mobile sign in with Rainbow wallet using WalletConnect login
- Web sign in with Rainbow wallet using Rainbow login
- Web sign in with Rainbow wallet using WalletConnect login
- Web sign in with Metamask wallet

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2023, 10:09 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 10:09 AM

ashoat added inline comments.Oct 9 2023, 10:10 AM

lib/utils/wagmi-utils.js
49–66	For context, this is the other location of the duplicated code

ashoat added a child revision: D9433: [lib] Stop using Ethers.js client from Wagmi.Oct 9 2023, 10:10 AM

ashoat edited the test plan for this revision. (Show Details)Oct 9 2023, 10:15 AM

Harbormaster completed remote builds in B23113: Diff 31819.Oct 9 2023, 10:26 AM

ashoat requested review of this revision.Oct 9 2023, 10:26 AM

atul accepted this revision.Oct 9 2023, 11:22 AM

This revision is now accepted and ready to land.Oct 9 2023, 11:22 AM

Closed by commit rCOMMd8339b2979f1: [landing] Reduce code duplication in landing/siwe.react.js (authored by ashoat). · Explain WhyOct 10 2023, 6:22 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd8339b2979f1: [landing] Reduce code duplication in landing/siwe.react.js.

Revision Contents
Changeset List

Path

Size

landing/

36 lines

lib/

utils/

8 lines

Diff 31819

landing/siwe.react.js

Loading...

lib/utils/wagmi-utils.js

Loading...