[lib] Stop using Ethers.js client from Wagmi
ClosedPublic
Actions

Authored by ashoat on Oct 9 2023, 10:10 AM.

Details

Reviewers

Commits

Summary

In Wagmi 1.0 they switch from Ethers.js to their in-house alternative Viem.

Our ENSCache code is built on Ethers.js. I'll consider migrating that to Viem, but for now the easiest thing is to decouple it.

Depends on D9432

Test Plan

Confirm that ENS resolution still works on mobile and web by opening up the inbox when I have recently chatted with an ENS user, and confirm that they ENS name is displayed
In combination with other diffs in the stack, I tested the following on both my local environment, and in a staging environment for my keyserver on comm.domains:
- Mobile sign in with Rainbow wallet using Rainbow login
- Mobile sign in with Rainbow wallet using WalletConnect login
- Web sign in with Rainbow wallet using Rainbow login
- Web sign in with Rainbow wallet using WalletConnect login
- Web sign in with Metamask wallet

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

ashoat edited the test plan for this revision. (Show Details)Oct 9 2023, 10:12 AM

ashoat edited the test plan for this revision. (Show Details)Oct 9 2023, 10:15 AM

ashoat requested review of this revision.Oct 9 2023, 10:27 AM

atul added inline comments.

landing/siwe.react.js
162–173	Probably some room for memoization here, but don't think performance is a concern w/ `landing` so makes sense to leave as is (more readable imo) {F805831}