Page MenuHomePhabricator

[native] Update height calculations for SIWEPanel
ClosedPublic

Authored by ashoat on Oct 9 2023, 1:14 PM.
Tags
None
Referenced Files
F3332659: D9437.id31828.diff
Thu, Nov 21, 12:51 AM
F3329206: D9437.id31865.diff
Wed, Nov 20, 4:39 PM
F3329205: D9437.id31835.diff
Wed, Nov 20, 4:39 PM
F3329204: D9437.id31828.diff
Wed, Nov 20, 4:39 PM
F3329203: D9437.id31825.diff
Wed, Nov 20, 4:39 PM
F3329083: D9437.id.diff
Wed, Nov 20, 4:37 PM
F3328892: D9437.diff
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Fri, Nov 15, 12:41 AM
Subscribers

Details

Summary

Two changes here:

  1. I updated the manually-determined offsets we use for the WalletConnect modal height. I did this by playing around with the modal and picking numbers that made it look good.
  2. I added some consideration for the keyboard height, since it's possible to search the WalletConnect modal. To achieve this, I had to introduce a new useKeyboardHeight hook.

Depends on D9436

Test Plan

I tested the WalletConnect modal:

  1. Tested iOS and Android physical devices
  2. Tested in a public staging environment (comm.domains)
  3. Tested the QR code scan feature on web
  4. Tested expanding to see "All wallets"
  5. Tested selecting a wallet (Rainbow)
  6. Tested searching for a wallet by typing a query

Some videos of the testing can be seen in the final diff in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I should mention that I did look at these docs:

Unfortunately none of those options helped us. It looks like they don't work well for a BottomSheet where the input element is coming from a WebView rather than React Native components.

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2023, 1:25 PM
Harbormaster failed remote builds in B23118: Diff 31825!

Remove console.logs to fix CI

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2023, 1:52 PM
Harbormaster failed remote builds in B23121: Diff 31828!
ashoat requested review of this revision.Oct 9 2023, 2:28 PM
This revision is now accepted and ready to land.Oct 9 2023, 2:42 PM