Page MenuHomePhabricator
Differential D9438

[landing] Update Lottie packages
ClosedPublic
Actions

Authored by ashoat on Oct 9 2023, 1:15 PM.
Tags
None
Referenced Files
F3340052: D9438.diff
Thu, Nov 21, 9:15 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
View All 97 Files
Subscribers
tomek
will

Details

Reviewers
rohan
atul
ginsu
Commits
rCOMMe2e29d561365: [landing] Update Lottie packages
Summary

With this change, we were seeing this issue with the WalletConnect modal.

Depends on D9437

Test Plan

For this diff:

  1. I confirmed the issue was gone
  2. I confirmed that the Lottie animations still worked on landing

For the whole stack:

I tested the WalletConnect modal:

  1. Tested iOS and Android physical devices
  2. Tested in a public staging environment (comm.domains)
  3. Tested the QR code scan feature on web
  4. Tested expanding to see "All wallets"
  5. Tested selecting a wallet (Rainbow)
  6. Tested searching for a wallet by typing a query

Separately, in combination with other diffs in the stack, I tested:

  • Mobile sign in with Rainbow wallet using Rainbow login
  • Mobile sign in with Rainbow wallet using WalletConnect login
  • Web sign in with Rainbow wallet using Rainbow login
  • Web sign in with Rainbow wallet using WalletConnect login
  • Web sign in with Metamask wallet

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2023, 1:15 PM
Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 1:16 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2023, 1:26 PM
Harbormaster failed remote builds in B23119: Diff 31826!
ashoat updated this revision to Diff 31829.Oct 9 2023, 1:38 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2023, 1:52 PM
Harbormaster failed remote builds in B23122: Diff 31829!
ashoat updated this revision to Diff 31836.Oct 9 2023, 2:11 PM

Rebase

Harbormaster completed remote builds in B23129: Diff 31836.Oct 9 2023, 2:29 PM
ashoat requested review of this revision.Oct 9 2023, 2:29 PM
ginsu accepted this revision.Oct 9 2023, 2:43 PM
This revision is now accepted and ready to land.Oct 9 2023, 2:43 PM
ashoat added a comment.Oct 9 2023, 6:29 PM

I'm missing some test videos here. Will fill this in after I finish testing.

ashoat added a child revision: D9439: [lib] Fix render of ConnectedWalletInfo on landing.Oct 9 2023, 6:29 PM
ashoat updated this revision to Diff 31856.Oct 10 2023, 4:59 AM

Upgrade Lottie instead

ashoat retitled this revision from [landing] Force use of lit-html@2.8.0 to [landing] Update Lottie packages.Oct 10 2023, 4:59 AM
ashoat edited the test plan for this revision. (Show Details)

Changing this diff to upgrade Lottie packages instead. Way better idea than forcing a Yarn resolution that may break things in the future

Harbormaster completed remote builds in B23137: Diff 31856.Oct 10 2023, 5:20 AM
ashoat edited the test plan for this revision. (Show Details)Oct 10 2023, 6:12 AM
Closed by commit rCOMMe2e29d561365: [landing] Update Lottie packages (authored by ashoat). · Explain WhyOct 10 2023, 6:28 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe2e29d561365: [landing] Update Lottie packages.

Revision Contents
Changeset List

PathSize
3 lines
14 lines

Diff 31826

View Options

package.json

Loading...
View Options

yarn.lock

Loading...