[identity] verify nonce in siwe message
ClosedPublic
Actions

Authored by varun on Oct 9 2023, 9:11 PM.

Details

Reviewers

kamil
bartek
• jon

Commits

rCOMM04be4bd3ba84: [identity] verify nonce in siwe message

Summary

get the nonce from the SIWE message provided by the user and check if it exists in our nonces table. if it doesn't, return an error. if it does, remove it and proceed.

Depends on D9440

Test Plan

tried to use the same nonce for consecutive sign-in requests and only the first request succeeded.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 9 2023, 9:11 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 9 2023, 9:11 PM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B23136: Diff 31850.Oct 9 2023, 9:28 PM

varun requested review of this revision.Oct 9 2023, 9:28 PM

bartek accepted this revision.Oct 9 2023, 11:20 PM

This revision is now accepted and ready to land.Oct 9 2023, 11:20 PM

varun added a child revision: D9448: [shared] add new interceptor to identity gRPC clients.Oct 10 2023, 9:20 PM

Closed by commit rCOMM04be4bd3ba84: [identity] verify nonce in siwe message (authored by varun). · Explain WhyOct 10 2023, 9:25 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM04be4bd3ba84: [identity] verify nonce in siwe message.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

19 lines

siwe.rs

6 lines

Diff 31887

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	SQL`

CREATE TABLE sessions (		CREATE TABLE sessions (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
user bigint(20) NOT NULL,		user bigint(20) NOT NULL,
cookie bigint(20) NOT NULL,		cookie bigint(20) NOT NULL,
query json NOT NULL,		query json NOT NULL,
creation_time bigint(20) NOT NULL,		creation_time bigint(20) NOT NULL,
last_update bigint(20) NOT NULL,		last_update bigint(20) NOT NULL,
last_validated bigint(20) NOT NULL		last_validated bigint(20) NOT NULL,
		public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;		) ENGINE=InnoDB DEFAULT CHARSET=latin1;

CREATE TABLE threads (		CREATE TABLE threads (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
type tinyint(3) NOT NULL,		type tinyint(3) NOT NULL,
name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,		name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
description mediumtext COLLATE utf8mb4_bin,		description mediumtext COLLATE utf8mb4_bin,
parent_thread_id bigint(20) DEFAULT NULL,		parent_thread_id bigint(20) DEFAULT NULL,
Show All 30 Lines	SQL`
secret varchar(255) NOT NULL,		secret varchar(255) NOT NULL,
creation_time bigint(20) NOT NULL,		creation_time bigint(20) NOT NULL,
extra json DEFAULT NULL		extra json DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8;		) ENGINE=InnoDB DEFAULT CHARSET=utf8;

CREATE TABLE users (		CREATE TABLE users (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL,		username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL,
hash char(60) COLLATE utf8mb4_bin DEFAULT NULL,		hash char(60) COLLATE utf8mb4_bin NOT NULL,
avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,		avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
creation_time bigint(20) NOT NULL		creation_time bigint(20) NOT NULL,
		public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;		) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

CREATE TABLE relationships_undirected (		CREATE TABLE relationships_undirected (
user1 bigint(20) NOT NULL,		user1 bigint(20) NOT NULL,
user2 bigint(20) NOT NULL,		user2 bigint(20) NOT NULL,
status tinyint(1) UNSIGNED NOT NULL		status tinyint(1) UNSIGNED NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;		) ENGINE=InnoDB DEFAULT CHARSET=latin1;

▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	SQL`
ADD KEY entry (entry);		ADD KEY entry (entry);

ALTER TABLE roles		ALTER TABLE roles
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD KEY thread (thread);		ADD KEY thread (thread);

ALTER TABLE sessions		ALTER TABLE sessions
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD KEY user (user);		ADD KEY user (user),
		ADD UNIQUE INDEX public_key (public_key);

ALTER TABLE threads		ALTER TABLE threads
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX parent_thread_id (parent_thread_id),		ADD INDEX parent_thread_id (parent_thread_id),
ADD INDEX containing_thread_id (containing_thread_id),		ADD INDEX containing_thread_id (containing_thread_id),
ADD INDEX community (community);		ADD INDEX community (community);

ALTER TABLE updates		ALTER TABLE updates
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX user_time (user,time),		ADD INDEX user_time (user,time),
ADD INDEX target_time (target, time),		ADD INDEX target_time (target, time),
ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time),		ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time),
ADD INDEX user_key_type_time (user, \`key\`, type, time),		ADD INDEX user_key_type_time (user, \`key\`, type, time),
ADD INDEX user_key_time (user, \`key\`, time);		ADD INDEX user_key_time (user, \`key\`, time);

ALTER TABLE uploads		ALTER TABLE uploads
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX container (container);		ADD INDEX container (container);

ALTER TABLE users		ALTER TABLE users
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD UNIQUE KEY username (username);		ADD UNIQUE KEY username (username),
		ADD UNIQUE INDEX public_key (public_key);

ALTER TABLE relationships_undirected		ALTER TABLE relationships_undirected
ADD UNIQUE KEY user1_user2 (user1,user2),		ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1);		ADD UNIQUE KEY user2_user1 (user2,user1);

ALTER TABLE relationships_directed		ALTER TABLE relationships_directed
ADD UNIQUE KEY user1_user2 (user1,user2),		ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1);		ADD UNIQUE KEY user2_user1 (user2,user1);
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines