[native] Update `pruneThreadIDsSelector` to use `threadActivityStore`
ClosedPublic
Actions

Authored by atul on Oct 11 2023, 1:52 PM.

Details

Reviewers

ashoat
tomek
rohan
ginsu

Commits

rCOMM6a3fd495294b: [native] Update `pruneThreadIDsSelector` to use `threadActivityStore`

Summary

Update pruneThreadIDsSelector to use lastNavigatedTo from threadActivityStore instead of messageStore.threads.

Also as discussed w/ @ashoat, we can check threadMessageInfo.messageIDs.length instead of lastPruned to reduce unnecessarily adding threadIDs to threadIDsToPrune. lastPruned will be removed from threadActivityStore in a subsequent diff.

Depends on D9453

Test Plan

Change msInHour to small value to "trigger" pruning and log threadIDsToPrune. Verify pruning via Redux Devtools. Have done minimal preliminary testing, will test more thoroughly before landing.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Oct 11 2023, 1:52 PM

Herald added a subscriber: will. · View Herald TranscriptOct 11 2023, 1:52 PM

atul published this revision for review.Oct 11 2023, 1:55 PM

Harbormaster completed remote builds in B23195: Diff 31943.Oct 11 2023, 2:11 PM

atul added a child revision: D9469: [native] Update `nextMessagePruneTimeSelector` to use `threadActivityStore`.Oct 12 2023, 8:51 AM

ashoat accepted this revision.Oct 16 2023, 7:13 AM

This revision is now accepted and ready to land.Oct 16 2023, 7:13 AM

fix optional chaining

Harbormaster completed remote builds in B23298: Diff 32093.Oct 17 2023, 12:15 PM

Closed by commit rCOMM6a3fd495294b: [native] Update `pruneThreadIDsSelector` to use `threadActivityStore` (authored by atul). · Explain WhyOct 19 2023, 7:44 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6a3fd495294b: [native] Update `pruneThreadIDsSelector` to use `threadActivityStore`.

Revision Contents
Changeset List

Path

Size

native/

selectors/

message-selectors.js

9 lines

Diff 32201

View Options

native/selectors/message-selectors.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[native] Update `pruneThreadIDsSelector` to use `threadActivityStore`ClosedPublicActions