[native] Redux migration to remove `messageStore.threads[threadID].[lastPruned/lastNavigatedTo]`
ClosedPublic
Actions

Authored by atul on Oct 17 2023, 7:10 PM.

Details

Reviewers

ashoat
tomek
rohan
ginsu

Commits

rCOMM4d076dd67152: [native] Redux migration to remove `messageStore.threads[threadID].

Summary

Redux migration to remove messageStore.threads[threadID].[lastPruned/lastNavigatedTo].

We don't **really* need this since messageStore.threads is persisted by both Redux and SQLite so the SQLite SET_MESSAGE_STORE will override the messageStore.threads that were REHYDRATED as soon as the app is first opened anyways, but figure it doesn't hurt.

Depends on D9517

Test Plan

messageStore.threads looks as expected after migration completes.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Oct 17 2023, 7:10 PM

Herald added a subscriber: will. · View Herald TranscriptOct 17 2023, 7:10 PM

atul added a child revision: D9519: [lib] Remove `last_[navigated_to/pruned]` from `ClientDBThreadMessageInfo`.Oct 17 2023, 7:14 PM

atul published this revision for review.Oct 17 2023, 7:14 PM

Harbormaster completed remote builds in B23319: Diff 32129.Oct 17 2023, 7:29 PM

ashoat accepted this revision.Oct 18 2023, 1:40 PM

This revision is now accepted and ready to land.Oct 18 2023, 1:40 PM

Closed by commit rCOMM4d076dd67152: [native] Redux migration to remove `messageStore.threads[threadID]. (authored by atul). · Explain WhyOct 19 2023, 7:45 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4d076dd67152: [native] Redux migration to remove `messageStore.threads[threadID]..

Revision Contents
Changeset List

Path

Size

native/

redux/

persist.js

23 lines

Diff 32205

View Options

native/redux/persist.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[native] Redux migration to remove `messageStore.threads[threadID].[lastPruned/lastNavigatedTo]`ClosedPublicActions