[shared] helper functions to get/set version unsupported status
ClosedPublic
Actions

Authored by varun on Oct 12 2023, 10:30 PM.

Details

Reviewers

bartek
michal

Commits

rCOMM201428306436: [shared] helper functions to get/set version unsupported status

Summary

we'll use the setter on the identity service but it might be useful for other services in the future, too.
we'll check for the specific unsupported version status on the client side.

Depends on D9473

Test Plan

tested the setter with kreya by sending a ping (implemented later in stack). will test is_unsupported_version when i handle the status on the client side.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 12 2023, 10:30 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 10:30 PM

varun added a child revision: D9479: [identity] introduce new ping RPC and code version interceptor function.Oct 12 2023, 10:43 PM

Harbormaster completed remote builds in B23228: Diff 31984.Oct 12 2023, 10:46 PM

varun requested review of this revision.Oct 12 2023, 10:46 PM

Personally, I was a bit skeptical about using the Unimplemented status code for that, but this table suggest it's the correct use case.

This revision is now accepted and ready to land.Oct 13 2023, 3:51 AM

Closed by commit rCOMM201428306436: [shared] helper functions to get/set version unsupported status (authored by varun). · Explain WhyOct 18 2023, 8:00 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM201428306436: [shared] helper functions to get/set version unsupported status.

Revision Contents
Changeset List

Path

Size

shared/

grpc_clients/

src/

error.rs

11 lines

Diff 32166

View Options

shared/grpc_clients/src/error.rs

Show All 29 Lines	import {
threadPermissions,		threadPermissions,
threadTypes,		threadTypes,
} from 'lib/types/thread-types.js';		} from 'lib/types/thread-types.js';
import { updateTypes } from 'lib/types/update-types.js';		import { updateTypes } from 'lib/types/update-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';
import { promiseAll } from 'lib/utils/promises.js';		import { promiseAll } from 'lib/utils/promises.js';
import { firstLine } from 'lib/utils/string-utils.js';		import { firstLine } from 'lib/utils/string-utils.js';

		import { reportLinkUsage } from './link-updaters.js';
import { updateRoles } from './role-updaters.js';		import { updateRoles } from './role-updaters.js';
import {		import {
changeRole,		changeRole,
recalculateThreadPermissions,		recalculateThreadPermissions,
commitMembershipChangeset,		commitMembershipChangeset,
} from './thread-permission-updaters.js';		} from './thread-permission-updaters.js';
import createMessages from '../creators/message-creator.js';		import createMessages from '../creators/message-creator.js';
import { createUpdates } from '../creators/update-creator.js';		import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js';		import { dbQuery, SQL } from '../database/database.js';
import { fetchEntryInfos } from '../fetchers/entry-fetchers.js';		import { fetchEntryInfos } from '../fetchers/entry-fetchers.js';
		import { checkIfInviteLinkIsValid } from '../fetchers/link-fetchers.js';
import {		import {
fetchMessageInfos,		fetchMessageInfos,
fetchMessageInfoByID,		fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';		} from '../fetchers/message-fetchers.js';
import {		import {
fetchThreadInfos,		fetchThreadInfos,
fetchServerThreadInfos,		fetchServerThreadInfos,
determineThreadAncestry,		determineThreadAncestry,
} from '../fetchers/thread-fetchers.js';		} from '../fetchers/thread-fetchers.js';
import {		import {
checkThreadPermission,		checkThreadPermission,
viewerIsMember as fetchViewerIsMember,		viewerIsMember as fetchViewerIsMember,
checkThread,		checkThread,
validateCandidateMembers,		validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js';		} from '../fetchers/thread-permission-fetchers.js';
import {		import {
verifyUserIDs,		verifyUserIDs,
verifyUserOrCookieIDs,		verifyUserOrCookieIDs,
} from '../fetchers/user-fetchers.js';		} from '../fetchers/user-fetchers.js';
		import { handleAsyncPromise } from '../responders/handlers.js';
import type { Viewer } from '../session/viewer.js';		import type { Viewer } from '../session/viewer.js';
import RelationshipChangeset from '../utils/relationship-changeset.js';		import RelationshipChangeset from '../utils/relationship-changeset.js';

async function updateRole(		async function updateRole(
viewer: Viewer,		viewer: Viewer,
request: RoleChangeRequest,		request: RoleChangeRequest,
): Promise<ChangeThreadSettingsResult> {		): Promise<ChangeThreadSettingsResult> {
if (!viewer.loggedIn) {		if (!viewer.loggedIn) {
▲ Show 20 Lines • Show All 729 Lines • ▼ Show 20 Lines
async function joinThread(		async function joinThread(
viewer: Viewer,		viewer: Viewer,
request: ServerThreadJoinRequest,		request: ServerThreadJoinRequest,
): Promise<ThreadJoinResult> {		): Promise<ThreadJoinResult> {
if (!viewer.loggedIn) {		if (!viewer.loggedIn) {
throw new ServerError('not_logged_in');		throw new ServerError('not_logged_in');
}		}

const [isMember, hasPermission] = await Promise.all([		const permissionCheck = request.inviteLinkSecret
fetchViewerIsMember(viewer, request.threadID),		? checkIfInviteLinkIsValid(request.inviteLinkSecret, request.threadID)
checkThreadPermission(		: checkThreadPermission(
viewer,		viewer,
request.threadID,		request.threadID,
threadPermissions.JOIN_THREAD,		threadPermissions.JOIN_THREAD,
),		);
		const [isMember, hasPermission] = await Promise.all([
		fetchViewerIsMember(viewer, request.threadID),
		permissionCheck,
]);		]);
if (!hasPermission) {		if (!hasPermission) {
throw new ServerError('invalid_parameters');		throw new ServerError('invalid_parameters');
}		}

// TODO: determine code version		// TODO: determine code version
const hasCodeVersionBelow87 = !hasMinCodeVersion(viewer.platformDetails, 87);		const hasCodeVersionBelow87 = !hasMinCodeVersion(viewer.platformDetails, 87);
const hasCodeVersionBelow62 = !hasMinCodeVersion(viewer.platformDetails, 62);		const hasCodeVersionBelow62 = !hasMinCodeVersion(viewer.platformDetails, 62);
Show All 29 Lines	): Promise<ThreadJoinResult> {
}		}

const changeset = await changeRole(request.threadID, [viewer.userID], null);		const changeset = await changeRole(request.threadID, [viewer.userID], null);

const membershipResult = await commitMembershipChangeset(viewer, changeset, {		const membershipResult = await commitMembershipChangeset(viewer, changeset, {
calendarQuery,		calendarQuery,
});		});

		if (request.inviteLinkSecret) {
		handleAsyncPromise(reportLinkUsage(request.inviteLinkSecret));
		}

const messageData = {		const messageData = {
type: messageTypes.JOIN_THREAD,		type: messageTypes.JOIN_THREAD,
threadID: request.threadID,		threadID: request.threadID,
creatorID: viewer.userID,		creatorID: viewer.userID,
time: Date.now(),		time: Date.now(),
};		};
const newMessages = await createMessages(viewer, [messageData]);		const newMessages = await createMessages(viewer, [messageData]);

▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines

[shared] helper functions to get/set version unsupported statusClosedPublicActions