Page MenuHomePhabricator
Differential D9472

[commtest] use shared/grpc_client for identity clients
ClosedPublic
Actions

Authored by varun on Oct 12 2023, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 4:29 PM
Unknown Object (File)
Mon, Oct 28, 7:46 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:31 PM
Unknown Object (File)
Sep 26 2024, 5:24 PM
Unknown Object (File)
Sep 19 2024, 8:46 PM
View All 62 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
bartek
michal
• jon
Commits
rCOMM695f3464b34b: [commtest] use shared/grpc_client for identity clients
Summary

remove all custom clients and replace them with the grpc_clients library clients

Depends on D9471

Test Plan

ran cargo test and all tests but an unrelated backup integration test passed (wasn't running backup service)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Oct 12 2023, 11:56 AM
Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 11:56 AM
Herald added subscribers: will, tomek, ashoat. · View Herald Transcript
varun added a child revision: D9473: [keyserver] change function names for getting clients to be more intuitive.Oct 12 2023, 11:57 AM
Harbormaster completed remote builds in B23219: Diff 31975.Oct 12 2023, 12:19 PM
varun requested review of this revision.Oct 12 2023, 12:19 PM
bartek accepted this revision.Oct 16 2023, 12:42 AM

Looks good. Conflicts a bit with my commtest changes, but I'll rebase as soon as you land this

services/commtest/build.rs
11–15 ↗(On Diff #31975)

This is not a perfect solution. It can stay for now but we should design something else for long term.
Can you create a follow-up task for this? E.g. under ENG-2311 or 4686

This revision is now accepted and ready to land.Oct 16 2023, 12:42 AM
varun added inline comments.Oct 18 2023, 7:20 PM
services/commtest/build.rs
11–15 ↗(On Diff #31975)

https://linear.app/comm/issue/ENG-5297/compile-all-protobuf-files-in-grpc-clients-and-potentially-rename-the

Closed by commit rCOMM695f3464b34b: [commtest] use shared/grpc_client for identity clients (authored by varun). · Explain WhyOct 18 2023, 8:00 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM695f3464b34b: [commtest] use shared/grpc_client for identity clients.

Revision Contents
Changeset List

Diff 32164

View Options

services/commtest/Cargo.lock

Loading...
View Options

services/commtest/Cargo.toml

Loading...
View Options

services/commtest/build.rs

Loading...
View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/tests/identity_access_tokens_tests.rs

Loading...
View Options

services/commtest/tests/identity_keyserver_tests.rs

Loading...
View Options

services/commtest/tests/identity_one_time_key_tests.rs

Loading...
View Options

services/commtest/tests/identity_prekey_tests.rs

Loading...
View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...