Page MenuHomePhabricator

[commtest] use shared/grpc_client for identity clients
ClosedPublic

Authored by varun on Oct 12 2023, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 7:46 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:34 PM
Unknown Object (File)
Sat, Oct 26, 10:31 PM
Unknown Object (File)
Sep 26 2024, 5:24 PM
Unknown Object (File)
Sep 19 2024, 8:46 PM
Unknown Object (File)
Sep 19 2024, 6:07 PM
Subscribers

Details

Summary

remove all custom clients and replace them with the grpc_clients library clients

Depends on D9471

Test Plan

ran cargo test and all tests but an unrelated backup integration test passed (wasn't running backup service)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Looks good. Conflicts a bit with my commtest changes, but I'll rebase as soon as you land this

services/commtest/build.rs
11–15

This is not a perfect solution. It can stay for now but we should design something else for long term.
Can you create a follow-up task for this? E.g. under ENG-2311 or 4686

This revision is now accepted and ready to land.Oct 16 2023, 12:42 AM