Page MenuHomePhabricator
Differential D9499

[lib/native/web] make user entity prop types read only
ClosedPublic
Actions

Authored by ginsu on Oct 15 2023, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 8:00 PM
Unknown Object (File)
Sun, Mar 16, 9:32 PM
Unknown Object (File)
Thu, Mar 13, 4:52 PM
Unknown Object (File)
Thu, Mar 13, 4:52 PM
Unknown Object (File)
Thu, Mar 13, 4:52 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:44 PM
Unknown Object (File)
Feb 27 2025, 4:33 PM
View All 92 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
ashoat
Commits
rCOMM2daf796ac10d: [lib/native/web] make user entity prop types read only
Summary

In D9389, I introduced some compoenents that didn't have read only prop types. This diff fixes that

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
2 lines
native/
chat/
4 lines
web/
chat/
4 lines

Diff 32125

View Options

lib/utils/entity-text.js

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

native/chat/inner-robotext-message.react.js

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

web/chat/robotext-message.react.js

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines