[web/keyserver] Separate web and keyserver versions
ClosedPublic
Actions

Authored by michal on Oct 16 2023, 5:55 AM.

Details

Reviewers

inka
kamil
atul

Commits

rCOMM584f14b7b6b3: [web/keyserver] Separate web and keyserver versions

Summary

ENG-4766

We need to separate web and keyserver for the future multi keyserver world. One of the things we need to change is versioning - they both need to have a separate versions.

Test Plan

yarn flow-all, cargo test in rust node addon. Checked if after changing the version the version in generated rust code also changes.

Diff Detail

Repository

rCOMM Comm

Branch

michal/web-separation-url-facts

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Oct 16 2023, 5:55 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 16 2023, 5:55 AM

Harbormaster completed remote builds in B23264: Diff 32039.Oct 16 2023, 6:24 AM

michal requested review of this revision.Oct 16 2023, 6:24 AM

After landing this diff, please send a message in the Releases channel to make sure I'm aware that the "bump version" commit will have to be changed. For now I'll continue to bump these versions in tandem

Seems reasonable

This revision is now accepted and ready to land.Oct 19 2023, 11:24 AM

Rebase

Harbormaster completed remote builds in B23569: Diff 32499.Oct 30 2023, 8:01 AM

Closed by commit rCOMM584f14b7b6b3: [web/keyserver] Separate web and keyserver versions (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 31 2023, 2:55 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM584f14b7b6b3: [web/keyserver] Separate web and keyserver versions.