[web] update usePushUserProfileModal hook args
AbandonedPublic
Actions

Authored by ginsu on Oct 16 2023, 10:53 PM.

Details

Reviewers

atul
inka

Summary

This diff addresses a concern in D9481 where the usePushUserProfileModal arguments could have been improved by making them read-only as a Props object

Test Plan

flow + confirmed everything still worked

Diff Detail

Repository

rCOMM Comm

Branch

eng-3998 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 16 2023, 10:53 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 16 2023, 10:53 PM

ginsu added reviewers: atul, inka.Oct 16 2023, 10:54 PM

ginsu mentioned this in D9476: [web] introduce usePushUserProfileModal hook.

Harbormaster completed remote builds in B23281: Diff 32058.Oct 16 2023, 11:10 PM

ginsu requested review of this revision.Oct 16 2023, 11:10 PM

Actually, I have no idea why I gave that feedback in D9476... it's a hook not a functional component so having userID: string as an argument makes more sense than a Props object.

Sorry about the confusion, feel free to abandon

This revision is now accepted and ready to land.Oct 17 2023, 9:23 AM

ginsu abandoned this revision.Oct 17 2023, 11:17 AM