Page MenuHomePhabricator
Differential D9522

[native] Remove extraneous SQLite deletion alerts
ClosedPublic
Actions

Authored by atul on Oct 18 2023, 7:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:50 AM
Unknown Object (File)
Sun, Apr 28, 6:47 AM
Unknown Object (File)
Sun, Apr 28, 6:24 AM
Unknown Object (File)
Wed, Apr 24, 2:41 AM
Unknown Object (File)
Mar 28 2024, 5:01 PM
Unknown Object (File)
Mar 28 2024, 5:01 PM
View All 26 Files
Subscribers
ashoat
will

Details

Reviewers
tomek
ginsu
rohan
kamil
Commits
rCOMMc657658277d7: [native] Remove extraneous SQLite deletion alerts
Summary

Context on Linear: https://linear.app/comm/issue/ENG-5165/remove-extraneous-alerts-from-native-app

Removing these alerts since they're mostly noise at this point and can make working with iOS in Simulator pretty frustrating.

Could also maybe improve situation w/ https://linear.app/comm/issue/ENG-5160/fix-sqlitedatahandler-re-renders

Test Plan

native app continues to work as expected. Confirmed that things still work as expected by observing the logging I added to replace Alerts.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Oct 18 2023, 7:45 AM
Herald added subscribers: will, ashoat. · View Herald TranscriptOct 18 2023, 7:45 AM
atul published this revision for review.Oct 18 2023, 7:45 AM
atul added inline comments.
native/data/sqlite-data-handler.js
94 ↗(On Diff #32149)

Figure it doesn't hurt to leave this in. Can remove if people feel strongly.

Harbormaster completed remote builds in B23332: Diff 32149.Oct 18 2023, 8:03 AM
rohan accepted this revision.EditedOct 18 2023, 11:54 AM

Seems reasonable to me, but don't have much context on the SQLiteDataHandler (regarding ENG-5160)

This revision is now accepted and ready to land.Oct 18 2023, 11:54 AM
atul updated this revision to Diff 32197.Oct 19 2023, 7:12 AM

rebase and land

Harbormaster completed remote builds in B23363: Diff 32197.Oct 19 2023, 7:37 AM
Closed by commit rCOMMc657658277d7: [native] Remove extraneous SQLite deletion alerts (authored by atul). · Explain WhyOct 19 2023, 7:45 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc657658277d7: [native] Remove extraneous SQLite deletion alerts.
ashoat added inline comments.Feb 9 2024, 4:36 PM
native/data/sqlite-data-handler.js
44

We should have removed this line when we did this

214

This line seems to have been accidentally added in D5995

Revision Contents
Changeset List

PathSize
native/
data/
12 lines

Diff 32207

View Options

native/data/sqlite-data-handler.js

Loading...