Page MenuHomePhabricator
Differential D9554

[web] update AppearanceChangeModal buttons to use redux state
ClosedPublic
Actions

Authored by ginsu on Oct 20 2023, 12:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 4:49 AM
Unknown Object (File)
Sun, Apr 28, 3:51 PM
Unknown Object (File)
Apr 22 2024, 10:57 AM
Unknown Object (File)
Apr 22 2024, 10:57 AM
Unknown Object (File)
Apr 22 2024, 10:57 AM
Unknown Object (File)
Apr 22 2024, 10:57 AM
Unknown Object (File)
Apr 22 2024, 10:54 AM
Unknown Object (File)
Apr 7 2024, 7:04 PM
View All 25 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM3c42ecffc737: [web] update AppearanceChangeModal buttons to use redux state
Summary

Right now the updating the theme state is just localized to a useState in AppearanceChangeModal. Now that we have globalThemeInfo in our redux state we should update and use that instead.

Part of https://linear.app/comm/issue/ENG-4958/update-theme-based-on-the-active-theme-redux-state

Depends on D9553

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 20 2023, 12:44 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 20 2023, 12:44 AM
ginsu edited the summary of this revision. (Show Details)Oct 20 2023, 12:47 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D9553: [lib/native] introduce useUpdateThemePreference.
ginsu attached a referenced file: F827012: Screen Recording 2023-10-20 at 3.46.56 AM.mov. (Show Details)
Harbormaster completed remote builds in B23397: Diff 32247.Oct 20 2023, 1:00 AM
ginsu requested review of this revision.Oct 20 2023, 1:00 AM
atul accepted this revision.Oct 20 2023, 10:50 AM
atul added inline comments.
web/settings/appearance-change-modal.react.js
39–58 ↗(On Diff #32247)

Out of scope of this diff, but while you have the file open... doesn't hurt to memoize this guy

This revision is now accepted and ready to land.Oct 20 2023, 10:50 AM
ginsu updated this revision to Diff 32323.Oct 23 2023, 11:06 AM

address @atul's comments + rebase before landing

This revision was landed with ongoing or failed builds.Oct 23 2023, 11:15 AM
Closed by commit rCOMM3c42ecffc737: [web] update AppearanceChangeModal buttons to use redux state (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3c42ecffc737: [web] update AppearanceChangeModal buttons to use redux state.
Harbormaster completed remote builds in B23431: Diff 32323.Oct 23 2023, 11:24 AM

Revision Contents
Changeset List

PathSize
web/
settings/
66 lines

Diff 32328

View Options

web/settings/appearance-change-modal.react.js

Loading...