Page MenuHomePhabricator
Differential D9565

[native] introduce Keyserver selection settings panel in user settings
ClosedPublic
Actions

Authored by ginsu on Oct 23 2023, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 3:25 PM
Unknown Object (File)
Wed, Nov 20, 5:48 PM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 7:59 AM
Unknown Object (File)
Oct 15 2024, 2:59 AM
View All 63 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
rohan
inka
michal
Commits
rCOMM80a3440fed66: [native] introduce Keyserver selection settings panel in user settings
Summary

This diff introduces the keyserver selection settings panel in user settings. This diff just introduces the element, and subsquent diffs will handle all the navigation/onPress logic

Figma designs:

Screenshot 2023-10-23 at 2.18.31 PM.png (1×858 px, 127 KB)

Linear task:
https://linear.app/comm/issue/ENG-4714/create-new-keyserver-selection-setting-panel-in-the-user-settings
https://linear.app/comm/issue/ENG-4912/gate-keyserver-selection-setting-panel-behind-staffcansee-flag

Test Plan

Please see screenshot below

Screenshot 2023-10-23 at 2.17.11 PM.png (1×1 px, 758 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 23 2023, 11:17 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 23 2023, 11:17 AM
ginsu published this revision for review.Oct 23 2023, 11:19 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: rohan, inka, michal.
ginsu attached a referenced file: F834085: Screenshot 2023-10-23 at 2.17.11 PM.png. (Show Details)
ginsu attached a referenced file: F834086: Screenshot 2023-10-23 at 2.18.31 PM.png. (Show Details)
ginsu added a child revision: D9566: [native] introduce barebones keyserver selection list screen.Oct 23 2023, 11:24 AM
Harbormaster completed remote builds in B23432: Diff 32329.Oct 23 2023, 11:34 AM
rohan accepted this revision.Oct 24 2023, 11:03 AM
This revision is now accepted and ready to land.Oct 24 2023, 11:03 AM
ginsu updated this revision to Diff 32360.Oct 24 2023, 1:28 PM

rebase before landing

Harbormaster completed remote builds in B23460: Diff 32360.Oct 24 2023, 2:04 PM
Closed by commit rCOMM80a3440fed66: [native] introduce Keyserver selection settings panel in user settings (authored by ginsu). · Explain WhyOct 24 2023, 2:42 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM80a3440fed66: [native] introduce Keyserver selection settings panel in user settings.

Revision Contents
Changeset List

PathSize
native/
profile/
14 lines

Diff 32360

View Options

native/profile/profile-screen.react.js

Loading...