Page MenuHomePhabricator
Differential D9590

[native] introduce Add keyserver screen UI
ClosedPublic
Actions

Authored by ginsu on Oct 24 2023, 8:37 PM.
Tags
None
Referenced Files
F2280344: D9590.id.diff
Mon, Jul 15, 6:12 PM
Unknown Object (File)
Mon, Jul 15, 2:40 PM
Unknown Object (File)
Sun, Jul 14, 2:39 AM
Unknown Object (File)
Sat, Jul 13, 4:06 PM
Unknown Object (File)
Sat, Jul 13, 2:51 PM
Unknown Object (File)
Sat, Jul 13, 12:13 PM
Unknown Object (File)
Fri, Jul 12, 9:06 AM
Unknown Object (File)
Wed, Jul 10, 1:02 AM
View All 66 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
rohan
michal
Commits
rCOMM50808c71ec3f: [native] introduce Add keyserver screen UI
Summary

This diff introduces and implements the UI for the add keyserver screen. The logic for the onPressSave callback will be implemented in subsequent diffs

Figma designs:

Screenshot 2023-10-24 at 11.43.03 PM.png (1×1 px, 219 KB)

Linear task: https://linear.app/comm/issue/ENG-5409/implement-ui-for-the-add-keyserver-input-screen

Depends on D9587

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 24 2023, 8:37 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 24 2023, 8:37 PM
ginsu edited the summary of this revision. (Show Details)Oct 24 2023, 8:44 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu added a parent revision: D9587: [native] introduce KeyserverSelectionListAddButton.
ginsu attached a referenced file: F836432: Screen Recording 2023-10-24 at 11.43.49 PM.mov. (Show Details)
ginsu attached a referenced file: F836430: Screenshot 2023-10-24 at 11.43.03 PM.png. (Show Details)
ginsu updated this revision to Diff 32383.Oct 24 2023, 8:54 PM

update

Harbormaster completed remote builds in B23474: Diff 32382.Oct 24 2023, 8:56 PM
ginsu updated this revision to Diff 32384.Oct 24 2023, 8:58 PM

update

ginsu added a child revision: D9591: [native] introduce addKeyserverActionType.Oct 24 2023, 9:13 PM
Harbormaster completed remote builds in B23475: Diff 32383.Oct 24 2023, 9:24 PM
Harbormaster completed remote builds in B23476: Diff 32384.Oct 24 2023, 9:28 PM
ginsu requested review of this revision.Oct 24 2023, 9:28 PM
michal accepted this revision.Oct 30 2023, 9:09 AM

LGTM although I haven't been really working with react native code lately. Do the diffs for filling in the missing // TODO exist?

This revision is now accepted and ready to land.Oct 30 2023, 9:09 AM
ginsu added a comment.Oct 31 2023, 9:41 PM

Do the diffs for filling in the missing // TODO exist?

Sorry probably should have been more clear in the description, but D9665 will handle this

ginsu updated this revision to Diff 32580.Oct 31 2023, 9:42 PM

rebase before landing

Harbormaster completed remote builds in B23634: Diff 32580.Oct 31 2023, 10:05 PM
Closed by commit rCOMM50808c71ec3f: [native] introduce Add keyserver screen UI (authored by ginsu). · Explain WhyOct 31 2023, 10:19 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM50808c71ec3f: [native] introduce Add keyserver screen UI.

Revision Contents
Changeset List

PathSize
native/
profile/
77 lines

Diff 32383

View Options

native/profile/add-keyserver.react.js

Loading...