Page MenuHomePhabricator
Differential D9619

Move database encryption utils to generic location
ClosedPublic
Actions

Authored by marcin on Oct 27 2023, 6:27 AM.
Tags
None
Referenced Files
F4120055: D9619.diff
Tue, Feb 18, 6:14 AM
Unknown Object (File)
Sun, Feb 16, 8:02 PM
Unknown Object (File)
Sat, Feb 15, 1:26 AM
Unknown Object (File)
Fri, Feb 14, 12:30 PM
Unknown Object (File)
Fri, Feb 14, 12:30 PM
Unknown Object (File)
Fri, Feb 14, 12:30 PM
Unknown Object (File)
Fri, Feb 14, 12:30 PM
Unknown Object (File)
Fri, Feb 14, 12:15 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
kamil
Commits
rCOMM3ffa0ab627e6: Move database encryption utils to generic location
Summary

AES_GCM functions used to encrypt/decrypt database are very generic and can be directly applied to olm notifications session encryption before it is
persisted in IndexedDB. We only need to move them to generic location and rename them.

Test Plan

Run yarn jest all since it wil run worker-crypto-utils.test.js that use all moved functions. This ensures that existing functionality wasn't broken.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Oct 27 2023, 6:27 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 27 2023, 6:27 AM
marcin updated this revision to Diff 32459.Oct 27 2023, 6:29 AM

Rebase to update commit message

marcin added a child revision: D9535: Initialize olm sessions for notifications on web and keyserver via socket requests.Oct 27 2023, 6:32 AM
marcin added a parent revision: D9534: Extract shareable notifications session creation logic to lib.
Harbormaster completed remote builds in B23533: Diff 32458.Oct 27 2023, 7:39 AM
Harbormaster completed remote builds in B23534: Diff 32459.Oct 27 2023, 7:45 AM
marcin requested review of this revision.Oct 27 2023, 7:45 AM
kamil accepted this revision.Oct 30 2023, 1:09 AM
This revision is now accepted and ready to land.Oct 30 2023, 1:09 AM
marcin updated this revision to Diff 33539.Nov 23 2023, 2:03 AM

Rebase before landing

Harbormaster completed remote builds in B24359: Diff 33539.Nov 23 2023, 3:20 AM
Closed by commit rCOMM3ffa0ab627e6: Move database encryption utils to generic location (authored by marcin). · Explain WhyNov 23 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3ffa0ab627e6: Move database encryption utils to generic location.

Revision Contents
Changeset List

PathSize
web/
crypto/
aes-gcm-crypto-utils.js/
database/
utils/
worker-crypto-utils.js
12 lines
database/
8 lines
utils/
38 lines
worker/
20 lines

Diff 32459

View Options

web/crypto/aes-gcm-crypto-utils.js

Loading...
View Options

web/database/database-module-provider.js

Loading...
View Options

web/database/utils/worker-crypto-utils.js

Loading...
View Options

web/database/utils/worker-crypto-utils.test.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...