Page MenuHomePhabricator

[native] Check isInvalidPinSource on native
ClosedPublic

Authored by rohan on Oct 30 2023, 9:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 9:08 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:36 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Thu, Nov 14, 2:23 PM
Unknown Object (File)
Wed, Nov 13, 7:36 PM
Unknown Object (File)
Sun, Nov 10, 11:37 AM
Subscribers

Details

Summary

There was an inconsistency where I check isInvalidPinSource on web, but not on native. This diff corrects that. The following diff will cover unifying this logic into a shared helper so the checks are done in one place.

Resolves https://linear.app/comm/issue/ENG-5618/check-isinvalidpinsource-on-native-in-the-toolitp

Test Plan

Confirmed that message pinning on native still works when expected:

  • For text messages
  • For multimedia messages
  • In sidebars if the message is not the first message

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Oct 30 2023, 9:43 AM

How come this adds isInvalidPinSource for both web and native? Is that because the diff that adds it to one and not the other hasn't been landed yet? Does that diff now need to be abandoned?

This revision is now accepted and ready to land.Oct 30 2023, 12:22 PM

How come this adds isInvalidPinSource for both web and native? Is that because the diff that adds it to one and not the other hasn't been landed yet? Does that diff now need to be abandoned?

Sorry, would you mind clarifying what you mean by "how come this adds isInvalidPinSource for both web and native"?

This diff only adds it into native to be consistent with when I added it for the web tooltip in D9445. In our meeting today we noticed that I forgot to include it on the native side.

The next diff in this stack is the 2nd step of what we discussed (unifying the logic / extracting common checks / etc)

Ah sorry, I thought this was updating web and native, but it's actually updating two places in native. We should obviously factor this out so we're not copy-pasting code, but I suppose that will be handled in the subsequent diff (as indicated in the diff description)

This revision was automatically updated to reflect the committed changes.