[native] display connnection state of keyserver
ClosedPublic
Actions

Authored by ginsu on Oct 31 2023, 1:32 AM.

Details

Reviewers

inka
rohan
michal

Commits

rCOMM4082f259b587: [native] display connnection state of keyserver

Summary

This diff adds the connection indicator of the keyservers in the keyserver selection list. For context here are the designs

Screenshot 2023-10-31 at 4.13.49 AM.png (1×764 px, 96 KB)

Linear task: https://linear.app/comm/issue/ENG-5369/show-connection-state-of-the-keyserver

Depends on D9642

Test Plan

Please see the screenshots below (the second keyserver is just a test "dummy" keyserver I added to the keyserver store when testing the add keyserver flow)

Screenshot 2023-10-31 at 4.34.07 AM.png (1×1 px, 704 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 31 2023, 1:32 AM

Herald added subscribers: will, • ted, tomek, ashoat. · View Herald TranscriptOct 31 2023, 1:32 AM

ginsu edited the summary of this revision. (Show Details)Oct 31 2023, 1:35 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, rohan, michal.

ginsu added a parent revision: D9642: [native] implement keyserver list ui.

ginsu attached a referenced file: F843836: Screenshot 2023-10-31 at 4.34.07 AM.png. (Show Details)

ginsu attached a referenced file: F843835: Screenshot 2023-10-31 at 4.13.49 AM.png. (Show Details)

ginsu added inline comments.Oct 31 2023, 1:38 AM

native/themes/colors.js
148–151 ↗	(On Diff #32521)	At this moment we did not have any good color variables for these new indicator elements. I think introducing these 4 elements is reasonable and based on the names given here we would be able to reuse these variables for other features

Harbormaster completed remote builds in B23586: Diff 32521.Oct 31 2023, 2:02 AM

ginsu requested review of this revision.Oct 31 2023, 2:02 AM

rohan accepted this revision.Nov 2 2023, 9:51 AM

rohan added inline comments.

native/profile/keyserver-selection-list.react.js
41–47 ↗	(On Diff #32521)	If this works it might be cleaner, but not a big deal so you can keep it if you prefer it the original way
native/themes/colors.js
148–151 ↗	(On Diff #32521)	I personally don't see an alternative besides introducing these so they seem ok to me. For sanity it'd be good to make sure they look fine on light mode, but I don't expect any problems there

This revision is now accepted and ready to land.Nov 2 2023, 9:51 AM

address comments + rebase before landing

ginsu added inline comments.Nov 2 2023, 12:04 PM

native/themes/colors.js
148–151 ↗	(On Diff #32521)	Confirmed that everything looks good in light mode:

ginsu attached a referenced file: F850527: Screenshot 2023-11-02 at 2.59.57 PM.png. (Show Details)Nov 2 2023, 12:04 PM

Harbormaster failed remote builds in B23689: Diff 32643!Nov 2 2023, 12:56 PM

Harbormaster completed remote builds in B23689: Diff 32643.Nov 2 2023, 1:42 PM

Closed by commit rCOMM4082f259b587: [native] display connnection state of keyserver (authored by ginsu). · Explain WhyNov 2 2023, 2:25 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM4082f259b587: [native] display connnection state of keyserver.

Revision Contents
Changeset List

Path

Size

native/

profile/

keyserver-selection-list.react.js

53 lines

themes/

colors.js

8 lines

Diff 32649

View Options

native/profile/keyserver-selection-list.react.js

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines	- [Debugging](./nix_web_workflows.md#debugging)
- [React Developer Tools](./nix_web_workflows.md#react-developer-tools)		- [React Developer Tools](./nix_web_workflows.md#react-developer-tools)
- [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools)		- [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools)
- [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript)		- [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript)
- [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows)		- [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows)
- [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator)		- [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator)
- [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator)		- [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator)
- [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices)		- [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices)
- [Shared workflows](./nix_shared_workflows.md#shared-workflows)		- [Shared workflows](./nix_shared_workflows.md#shared-workflows)
		- [Inspect database with TablePlus](./nix_shared_workflows.md#inspect-database-with-tableplus)
- [Codegen](./nix_shared_workflows.md#codegen)		- [Codegen](./nix_shared_workflows.md#codegen)
- [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi)		- [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi)
- [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc)		- [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc)
- [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator)		- [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator)
- [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff)		- [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff)
- [Updating a diff](./nix_shared_workflows.md#updating-a-diff)		- [Updating a diff](./nix_shared_workflows.md#updating-a-diff)
- [Working with a stack](./nix_shared_workflows.md#working-with-a-stack)		- [Working with a stack](./nix_shared_workflows.md#working-with-a-stack)
- [Committing a diff](./nix_shared_workflows.md#committing-a-diff)		- [Committing a diff](./nix_shared_workflows.md#committing-a-diff)
- [Final notes](./nix_shared_workflows.md#final-notes)		- [Final notes](./nix_shared_workflows.md#final-notes)

## How Nix introduces dependencies to a development environment		## How Nix introduces dependencies to a development environment

Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`.		Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`.