Page MenuHomePhabricator
Differential D9646

[lib] Get rid of SentencePrefixSearchIndex.entries
ClosedPublic
Actions

Authored by ashoat on Oct 31 2023, 5:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 10:06 PM
Unknown Object (File)
Sat, Mar 1, 11:13 AM
Unknown Object (File)
Sat, Mar 1, 10:55 AM
Unknown Object (File)
Sat, Mar 1, 10:55 AM
Unknown Object (File)
Sat, Mar 1, 9:34 AM
Unknown Object (File)
Jan 20 2025, 5:07 PM
Unknown Object (File)
Jan 20 2025, 5:07 PM
Unknown Object (File)
Jan 20 2025, 5:06 PM
View All 73 Files
Subscribers
will

Details

Reviewers
tomek
atul
inka
rohan
Commits
rCOMM5153064608b8: [lib] Get rid of SentencePrefixSearchIndex.entries
Summary

With PrefixTree we no longer need to special-case this.

Test Plan

I went to a community in my local environment and typed a single "@" character. I made sure the options displayed before/after were the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines
4 lines

Diff 32540

View Options

lib/shared/mention-utils.js

Show First 20 Lines • Show All 229 Lines • ▼ Show 20 Lines:root {
--dropdown-select-bg: var(--shades-black-90); --dropdown-select-bg: var(--shades-black-90);
--dropdown-select-border: var(--shades-white-60); --dropdown-select-border: var(--shades-white-60);
--dropdown-option-bg: var(--shades-black-80); --dropdown-option-bg: var(--shades-black-80);
--dropdown-option-hover-bg: var(--shades-black-70); --dropdown-option-hover-bg: var(--shades-black-70);
--dropdown-selected-option-check-color: var(--violet-dark-100); --dropdown-selected-option-check-color: var(--violet-dark-100);
--dropdown-disabled-color: var(--shades-black-60); --dropdown-disabled-color: var(--shades-black-60);
--change-member-role-modal-description-text: var(--shades-white-60); --change-member-role-modal-description-text: var(--shades-white-60);
--change-member-role-modal-generic-text: var(--shades-white-100); --change-member-role-modal-generic-text: var(--shades-white-100);
--unsaved-changes-modal-text-color: var(--shades-white-60);
} }
View Options

lib/shared/sentence-prefix-search-index.js

Show First 20 Lines • Show All 229 Lines • ▼ Show 20 Lines:root {
--dropdown-select-bg: var(--shades-black-90); --dropdown-select-bg: var(--shades-black-90);
--dropdown-select-border: var(--shades-white-60); --dropdown-select-border: var(--shades-white-60);
--dropdown-option-bg: var(--shades-black-80); --dropdown-option-bg: var(--shades-black-80);
--dropdown-option-hover-bg: var(--shades-black-70); --dropdown-option-hover-bg: var(--shades-black-70);
--dropdown-selected-option-check-color: var(--violet-dark-100); --dropdown-selected-option-check-color: var(--violet-dark-100);
--dropdown-disabled-color: var(--shades-black-60); --dropdown-disabled-color: var(--shades-black-60);
--change-member-role-modal-description-text: var(--shades-white-60); --change-member-role-modal-description-text: var(--shades-white-60);
--change-member-role-modal-generic-text: var(--shades-white-100); --change-member-role-modal-generic-text: var(--shades-white-100);
--unsaved-changes-modal-text-color: var(--shades-white-60);
} }