Page MenuHomePhabricator
Differential D9687

[lib] Introduce `threadRolePermissionsBlobToBitmaskArray`
ClosedPublic
Actions

Authored by atul on Nov 3 2023, 12:05 PM.
Tags
None
Referenced Files
F3744268: D9687.diff
Thu, Jan 9, 3:05 PM
Unknown Object (File)
Fri, Jan 3, 3:30 PM
Unknown Object (File)
Mon, Dec 16, 8:03 PM
Unknown Object (File)
Mon, Dec 16, 8:03 PM
Unknown Object (File)
Mon, Dec 16, 8:03 PM
Unknown Object (File)
Mon, Dec 16, 8:03 PM
Unknown Object (File)
Mon, Dec 16, 7:52 PM
Unknown Object (File)
Fri, Dec 13, 11:21 PM
View All 93 Files
Subscribers
will

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`
Summary

Returns threadRolePermissionsBlob as bitmask array.

Test Plan

Unit tests, will add more tests w/ decode

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 3 2023, 12:05 PM
Herald added a subscriber: will. · View Herald TranscriptNov 3 2023, 12:05 PM
atul updated this revision to Diff 32690.Nov 3 2023, 12:21 PM

shorten fn name

atul retitled this revision from [lib] Introduce `threadRolePermissionsBlobToRolePermissionBitmaskArray` to [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.Nov 3 2023, 12:21 PM
atul updated this revision to Diff 32691.Nov 3 2023, 12:22 PM

include all..

atul published this revision for review.Nov 3 2023, 12:22 PM
Harbormaster completed remote builds in B23727: Diff 32686.Nov 3 2023, 12:25 PM
Harbormaster completed remote builds in B23728: Diff 32690.Nov 3 2023, 12:40 PM
Harbormaster completed remote builds in B23729: Diff 32691.Nov 3 2023, 12:44 PM
atul added a child revision: D9689: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray`.Nov 3 2023, 12:46 PM
ashoat accepted this revision.Nov 5 2023, 5:28 PM
This revision is now accepted and ready to land.Nov 5 2023, 5:28 PM
Closed by commit rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray` (authored by atul). · Explain WhyNov 6 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.

Revision Contents
Changeset List

Diff 32691

View Options

lib/permissions/minimally-encoded-thread-permissions.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...