Page MenuHomePhabricator
Differential D9687

[lib] Introduce `threadRolePermissionsBlobToBitmaskArray`
ClosedPublic
Actions

Authored by atul on Nov 3 2023, 12:05 PM.
Tags
None
Referenced Files
F2208936: D9687.diff
Sun, Jul 7, 3:32 PM
F2205976: D9687.id32769.diff
Sat, Jul 6, 11:45 PM
F2205963: D9687.id32690.diff
Sat, Jul 6, 11:43 PM
Unknown Object (File)
Sat, Jul 6, 4:34 AM
Unknown Object (File)
Thu, Jul 4, 11:20 AM
Unknown Object (File)
Fri, Jun 28, 10:34 AM
Unknown Object (File)
Fri, Jun 28, 10:34 AM
Unknown Object (File)
Fri, Jun 28, 10:34 AM
View All 45 Files
Subscribers
will

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`
Summary

Returns threadRolePermissionsBlob as bitmask array.

Test Plan

Unit tests, will add more tests w/ decode

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 3 2023, 12:05 PM
Herald added a subscriber: will. · View Herald TranscriptNov 3 2023, 12:05 PM
atul updated this revision to Diff 32690.Nov 3 2023, 12:21 PM

shorten fn name

atul retitled this revision from [lib] Introduce `threadRolePermissionsBlobToRolePermissionBitmaskArray` to [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.Nov 3 2023, 12:21 PM
atul updated this revision to Diff 32691.Nov 3 2023, 12:22 PM

include all..

atul published this revision for review.Nov 3 2023, 12:22 PM
Harbormaster completed remote builds in B23727: Diff 32686.Nov 3 2023, 12:25 PM
Harbormaster completed remote builds in B23728: Diff 32690.Nov 3 2023, 12:40 PM
Harbormaster completed remote builds in B23729: Diff 32691.Nov 3 2023, 12:44 PM
atul added a child revision: D9689: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray`.Nov 3 2023, 12:46 PM
ashoat accepted this revision.Nov 5 2023, 5:28 PM
This revision is now accepted and ready to land.Nov 5 2023, 5:28 PM
Closed by commit rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray` (authored by atul). · Explain WhyNov 6 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.

Revision Contents
Changeset List

Diff 32691

View Options

lib/permissions/minimally-encoded-thread-permissions.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...