Paths

Table of Contentst

Differential D9735

[lib] Introduce `MinimallyEncodedMemberInfo` and validator
ClosedPublic
Actions

Authored by atul on Nov 6 2023, 11:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 10:56 AM

	Unknown Object (File)
	Sun, Nov 3, 10:56 AM

	Unknown Object (File)
	Sun, Nov 3, 10:56 AM

	Unknown Object (File)
	Sun, Nov 3, 10:56 AM

	Unknown Object (File)
	Sun, Nov 3, 10:56 AM

	Unknown Object (File)
	Sun, Nov 3, 10:55 AM

	Unknown Object (File)
	Sun, Nov 3, 10:54 AM

	Unknown Object (File)
	Fri, Oct 25, 11:56 PM

View All 83 Files

Subscribers

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM8485f33ca0cc: [lib] Introduce `MinimallyEncodedMemberInfo` and validator

Summary

MemberInfo type w/ permissions as string instread of ThreadPermissions.

Next diffs:

Introduce MinimallyEncodedRawThreadInfo
Higher level utilities for translating back/forth from RawThreadInfo <=> MinimallyEncodedRawThreadInfo. Found this to be cleaner API than encoding/decoding RawThreadInfo.currentUser.permissions and RawThreadInfo.members[memberID].permissions "manually" a bunch of different places.
Native refactoring + migrations
Web refactoring
Flipping the switch

Depends on D9734

Test Plan

Unit tests, will be tested implicitly in subsequent diffs as well.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 6 2023, 11:33 AM

Herald added a subscriber: will. · View Herald TranscriptNov 6 2023, 11:33 AM

atul published this revision for review.Nov 6 2023, 11:36 AM

ashoat accepted this revision.Nov 6 2023, 11:41 AM

This revision is now accepted and ready to land.Nov 6 2023, 11:41 AM

Harbormaster completed remote builds in B23810: Diff 32823.Nov 6 2023, 11:52 AM

rebase and land

land

fix test

This revision was landed with ongoing or failed builds.Nov 6 2023, 2:10 PM

Closed by commit rCOMM8485f33ca0cc: [lib] Introduce `MinimallyEncodedMemberInfo` and validator (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8485f33ca0cc: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

Harbormaster failed remote builds in B23819: Diff 32833!Nov 6 2023, 2:12 PM

Harbormaster failed remote builds in B23821: Diff 32836!Nov 6 2023, 2:20 PM

atul added a child revision: D9736: [lib] Introduce `MinimallyEncodedRawThreadInfo` and validator.Nov 6 2023, 2:51 PM

Harbormaster completed remote builds in B23822: Diff 32837.Nov 6 2023, 3:06 PM

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions.js

19 lines

minimally-encoded-thread-permissions.test.js

39 lines

types/

thread-types.js

2 lines

Diff 32838

lib/permissions/minimally-encoded-thread-permissions.js

Loading...

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...

lib/types/thread-types.js

Loading...