Page MenuHomePhabricator

[docker-compose] Update deprecated localstack config
ClosedPublic

Authored by bartek on Nov 7 2023, 4:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 10:54 AM
Unknown Object (File)
Oct 26 2024, 5:14 PM
Unknown Object (File)
Oct 14 2024, 12:09 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:17 PM
Unknown Object (File)
Oct 11 2024, 12:13 PM
Subscribers

Details

Summary

Details in ENG-5677.
Some of the config environment variables for Localstack are deprecated.
I've updated them according to the docs.

Depends on D9740

Test Plan
  • Run localstack locally and use it (e.g. integration tests)
  • Stop and restart localstack container, check if the data is still there (DDB and S3 items)
  • Run this on CI

Diff Detail

Repository
rCOMM Comm
Branch
barthap/localstack-ci
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 12 2023, 10:52 PM
bartek edited the test plan for this revision. (Show Details)
atul requested changes to this revision.Nov 13 2023, 9:25 AM

Requesting changes because I think HLOCALSTACK_HOST should be LOCALSTACK_HOST. Feel free to re-request if I'm missing something

services/docker-compose.yml
95 ↗(On Diff #32857)

Should this be LOCALSTACK_HOST instead of HLOCALSTACK_HOST?

Here's what I'm seeing from the docs you linked:

dcb8d7.png (160×2 px, 46 KB)

Maybe the H prefix has some meaning that I'm missing?

This revision now requires changes to proceed.Nov 13 2023, 9:25 AM
atul attached a referenced file: F872579: dcb8d7.png. (Show Details)

Actually, just make sure it's fixed before landing. Don't think it's worth requesting changes

This revision is now accepted and ready to land.Nov 13 2023, 9:25 AM