Page MenuHomePhabricator
Differential D9753

[native] introduce status indicator component
ClosedPublic
Actions

Authored by ginsu on Nov 7 2023, 11:24 AM.
Tags
None
Referenced Files
F3509810: D9753.id33020.diff
Sat, Dec 21, 8:32 AM
Unknown Object (File)
Fri, Dec 20, 1:03 PM
Unknown Object (File)
Fri, Dec 20, 2:05 AM
Unknown Object (File)
Thu, Dec 19, 11:24 AM
Unknown Object (File)
Thu, Dec 19, 10:53 AM
Unknown Object (File)
Tue, Dec 10, 8:37 AM
Unknown Object (File)
Tue, Dec 10, 6:57 AM
Unknown Object (File)
Mon, Dec 9, 7:04 PM
View All 82 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
rohan
michal
Commits
rCOMM6a469c053434: [native] introduce status indicator component
Summary

In the keyserver selection bottom sheet ui, I will need to add a status indicator again. Rather than copy + paste all the logic necessary for this, I decided to factor out the logic into its own component that can be reused anytime

Part of https://linear.app/comm/issue/ENG-5469/introduce-keyserverselectionbottomsheet-component-ui

Depends on D9726

Test Plan

flow and confirmed that the status indicator still looks and behaves the same in the keyserver selection list

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 7 2023, 11:24 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 7 2023, 11:24 AM
ginsu added reviewers: inka, rohan, michal.Nov 7 2023, 11:26 AM
ginsu edited the summary of this revision. (Show Details)Nov 7 2023, 11:28 AM
ginsu added a parent revision: D9726: [native] introduce barebones keyserver selection bottom sheet to root navigator.
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2023, 11:35 AM
Harbormaster failed remote builds in B23886: Diff 32919!
ginsu added a child revision: D9754: [native] introduce keyserver selection bottom sheet ui.Nov 7 2023, 11:37 AM
ginsu updated this revision to Diff 32922.Nov 7 2023, 11:56 AM

rebase

ginsu published this revision for review.Nov 7 2023, 11:20 PM
Harbormaster completed remote builds in B23889: Diff 32922.Nov 8 2023, 9:14 AM
inka accepted this revision.Nov 9 2023, 2:32 AM
This revision is now accepted and ready to land.Nov 9 2023, 2:32 AM
ginsu updated this revision to Diff 33020.Nov 9 2023, 10:52 AM

rebase before landing

ginsu updated this revision to Diff 33022.Nov 9 2023, 10:56 AM

rebase one more time (forgot to pull from master first)

Harbormaster completed remote builds in B23968: Diff 33020.Nov 9 2023, 11:37 AM
Harbormaster completed remote builds in B23970: Diff 33022.Nov 9 2023, 11:45 AM
Closed by commit rCOMM6a469c053434: [native] introduce status indicator component (authored by ginsu). · Explain WhyNov 9 2023, 12:33 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6a469c053434: [native] introduce status indicator component.

Revision Contents
Changeset List

PathSize
native/
components/
81 lines
profile/
60 lines

Diff 33032

View Options

native/components/status-indicator.react.js

Loading...
View Options

native/profile/keyserver-selection-list-item.react.js

Loading...