[lib] Update signatures of thread utils to handle `MinimallyEncodedRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 9 2023, 1:47 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMf63bc4642c36: [lib] Update signatures of thread utils to handle…

Summary

Updated utilities in thread-utils that just required updating signature. Will now go through and handle the ones that require some branching on minimallyEncoded, eg getCurrentUser, membersHasAdminPowers, threadMemberHasPermission, etc.

Depends on D9810

Test Plan

Flow, will add unit tests for these once refactor is done

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 9 2023, 1:47 PM

Herald added a subscriber: will. · View Herald TranscriptNov 9 2023, 1:47 PM

atul published this revision for review.Nov 9 2023, 1:47 PM

Not looking too closely; trusting Flow to catch any issues

This revision is now accepted and ready to land.Nov 9 2023, 1:56 PM

Harbormaster completed remote builds in B23979: Diff 33037.Nov 9 2023, 2:14 PM

atul added a child revision: D9832: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators.Nov 10 2023, 1:09 PM

Closed by commit rCOMMf63bc4642c36: [lib] Update signatures of thread utils to handle… (authored by atul). · Explain WhyNov 11 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMf63bc4642c36: [lib] Update signatures of thread utils to handle….

atul mentioned this in D9847: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.Nov 13 2023, 2:13 PM

atul mentioned this in rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.Nov 13 2023, 3:02 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

94 lines

Diff 33037

View Options

lib/shared/thread-utils.js

[lib] Update signatures of thread utils to handle `MinimallyEncodedRawThreadInfo`ClosedPublicActions