Page MenuHomePhabricator
Differential D9844

[lib] Update `hasPermission` to check `KNOW_OF`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 12:44 PM.
Tags
None
Referenced Files
F3245879: D9844.diff
Thu, Nov 14, 8:32 PM
Unknown Object (File)
Sun, Oct 20, 9:04 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:14 AM
Unknown Object (File)
Sep 19 2024, 7:07 PM
Unknown Object (File)
Sep 14 2024, 5:09 PM
View All 48 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM153470bd0b5e: [lib] Update `hasPermission` to check `KNOW_OF`
Summary

Context in this diff: https://phab.comm.dev/D9841

Depends on D9843

Test Plan

Introduced test case where hasPermission should've failed, and now does fail.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Nov 13 2023, 12:44 PM
atul mentioned this in D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.Nov 13 2023, 12:45 PM
atul added inline comments.Nov 13 2023, 12:47 PM
lib/permissions/minimally-encoded-thread-permissions.js
124–126 ↗(On Diff #33145)

Could alternatively AND the permissionBitmask and knowOfBitmask together before the check, but I think having two separate "JS conditions" would make things easier to debug

Open to going with that approach if preferred

atul published this revision for review.Nov 13 2023, 12:48 PM
ashoat accepted this revision.Nov 13 2023, 12:49 PM
This revision is now accepted and ready to land.Nov 13 2023, 12:49 PM
atul added a child revision: D9845: [lib] Update `threadHasPermission` to "go through" `permissionLookup`.Nov 13 2023, 1:03 PM
Harbormaster completed remote builds in B24055: Diff 33145.Nov 13 2023, 1:25 PM
Closed by commit rCOMM153470bd0b5e: [lib] Update `hasPermission` to check `KNOW_OF` (authored by atul). · Explain WhyNov 13 2023, 2:20 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM153470bd0b5e: [lib] Update `hasPermission` to check `KNOW_OF`.

Revision Contents
Changeset List

Diff 33156

View Options

lib/permissions/minimally-encoded-thread-permissions.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...