[web/native] Use useSearchUsers for the friends list
ClosedPublic
Actions

Authored by rohan on Nov 14 2023, 9:22 AM.

Details

Reviewers

atul
ginsu
inka

Commits

rCOMMd87df9dd068e: [web/native] Use useSearchUsers for the friends list

Summary

useSearchUsers is used to include user search results from the server (outside of the user's local userStore during the 'composing a new chat' flow on both web and native.

The code looks a little like the code in AddUsersList on web and RelationshipList on native when viewing your friends. Because of this, this diff is really useful in getting rid of a 'one off' search logic
and instead using a shared search helper. This will make it easier to do the next part of this stack (updating search helpers to lookup addresses from a typed out ENS name).

Addresses ENG-5490

Depends on D9883

Test Plan

Confirmed that searching for users outside of the user's local userStore still worked in these two search experiences. Made sure to compare the search experience to how it is on production right now as well to make sure no regressions were introduced.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 14 2023, 9:22 AM

rohan held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 9:22 AM

Harbormaster completed remote builds in B24116: Diff 33216.Nov 14 2023, 9:54 AM

rohan added a child revision: D9885: [lib] Detect a valid ENS name in search experiences.Nov 14 2023, 11:27 AM

rohan published this revision for review.Nov 15 2023, 7:33 AM

Attempt rebase after Flow stack

Harbormaster completed remote builds in B24574: Diff 33950.Nov 28 2023, 9:25 AM

This diff has been up for almost two weeks, and all three of the reviewers appear to be completely ignoring it.

This is unacceptable. Diffs should be reviewed within a single business day. Deferring a review for a couple days can happen sometimes, but two weeks is far too long.

If you are unable to review the diff you should resign from the review. Leaving it hanging like this is frankly being rude to your colleague. @atul, @inka, @ginsu – please review this diff ASAP, and please make sure that you do better in the future.

In D9884#293455, @ashoat wrote:

This diff has been up for almost two weeks, and all three of the reviewers appear to be completely ignoring it.

I did look at this diff a couple times, but deferred giving it a review because changes were requested on D9883 and I figured I'd review after the feedback there was addressed. Should've checked back on it more regularly... will review now.

sorry for not getting to this sooner!

This revision is now accepted and ready to land.Nov 28 2023, 1:30 PM

So sorry about this!

Closed by commit rCOMMd87df9dd068e: [web/native] Use useSearchUsers for the friends list (authored by rohan). · Explain WhyNov 29 2023, 6:02 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMd87df9dd068e: [web/native] Use useSearchUsers for the friends list.