Page MenuHomePhabricator
Differential D9917

[web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching
ClosedPublic
Actions

Authored by atul on Nov 16 2023, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 6:45 AM
Unknown Object (File)
Tue, Apr 1, 8:17 AM
Unknown Object (File)
Sat, Mar 29, 9:38 PM
Unknown Object (File)
Mon, Mar 17, 4:47 PM
Unknown Object (File)
Mon, Mar 17, 4:47 PM
Unknown Object (File)
Mon, Mar 17, 4:47 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:23 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMcdb3c25742e0: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching
Summary

Context: https://phab.comm.dev/D9907?id=33305#inline-61775

Basically pulling out the filter/map functionality to separate function where input is typed to avoid cut/paste and branching.

Open to any other approaches.

Depends on D9907

Test Plan

Flow/ESlint

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D9917 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
create/
steps/
81 lines

Diff 33375

View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

Show All 32 Lines
import ParentThreadHeader from './parent-thread-header.react.js'; import ParentThreadHeader from './parent-thread-header.react.js';
import ContentLoading from '../components/content-loading.react.js'; import ContentLoading from '../components/content-loading.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import { import {
OverlayContext, OverlayContext,
type OverlayContextType, type OverlayContextType,
} from '../navigation/overlay-context.js'; } from '../navigation/overlay-context.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { ThreadSettingsRouteName } from '../navigation/route-names.js'; import {
ThreadSettingsRouteName,
MessageResultsScreenRouteName,
} from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
type BaseProps = { type BaseProps = {
+navigation: ChatNavigationProp<'MessageList'>, +navigation: ChatNavigationProp<'MessageList'>,
+route: NavigationRoute<'MessageList'>, +route: NavigationRoute<'MessageList'>,
}; };
▲ Show 20 Lines • Show All 315 Lines • ▼ Show 20 Lines ) {
let bannerText; let bannerText;
if (!threadInfo.pinnedCount || threadInfo.pinnedCount === 0) { if (!threadInfo.pinnedCount || threadInfo.pinnedCount === 0) {
bannerText = ''; bannerText = '';
} else { } else {
const messageNoun = threadInfo.pinnedCount === 1 ? 'message' : 'messages'; const messageNoun = threadInfo.pinnedCount === 1 ? 'message' : 'messages';
bannerText = `${threadInfo.pinnedCount} pinned ${messageNoun}`; bannerText = `${threadInfo.pinnedCount} pinned ${messageNoun}`;
} }
const navigateToMessageResults = React.useCallback(() => {
props.navigation.navigate<'MessageResultsScreen'>({
name: MessageResultsScreenRouteName,
params: {
threadInfo,
},
key: `PinnedMessages${threadInfo.id}`,
});
}, [props.navigation, threadInfo]);
const pinnedCountBanner = React.useMemo(() => { const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) { if (!bannerText) {
return null; return null;
} }
return ( return (
<View style={styles.pinnedCountBanner}> <View style={styles.pinnedCountBanner}>
<Text style={styles.pinnedCountText}>{bannerText}</Text> <Text
onPress={navigateToMessageResults}
style={styles.pinnedCountText}
>
{bannerText}
</Text>
<Icon <Icon
name="chevron-right" name="chevron-right"
size={12} size={12}
color={colors.panelBackgroundLabel} color={colors.panelBackgroundLabel}
/> />
</View> </View>
); );
}, [ }, [
navigateToMessageResults,
bannerText, bannerText,
styles.pinnedCountBanner, styles.pinnedCountBanner,
styles.pinnedCountText, styles.pinnedCountText,
colors.panelBackgroundLabel, colors.panelBackgroundLabel,
]); ]);
return ( return (
<MessageListContextProvider threadInfo={threadInfo}> <MessageListContextProvider threadInfo={threadInfo}>
Show All 23 Lines