[web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching
ClosedPublic
Actions

Authored by atul on Nov 16 2023, 12:10 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMcdb3c25742e0: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching

Summary

Context: https://phab.comm.dev/D9907?id=33305#inline-61775

Basically pulling out the filter/map functionality to separate function where input is typed to avoid cut/paste and branching.

Open to any other approaches.

Depends on D9907

Test Plan

Flow/ESlint

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D9917 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 16 2023, 12:10 PM

atul published this revision for review.Nov 16 2023, 12:33 PM

atul mentioned this in D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.

Harbormaster failed remote builds in B24223: Diff 33359!Nov 16 2023, 12:41 PM

ashoat accepted this revision.Nov 16 2023, 1:19 PM

This revision is now accepted and ready to land.Nov 16 2023, 1:19 PM

land

This revision was landed with ongoing or failed builds.Nov 16 2023, 2:13 PM

Closed by commit rCOMMcdb3c25742e0: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMcdb3c25742e0: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching.

Harbormaster failed remote builds in B24238: Diff 33375!Nov 16 2023, 3:40 PM

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

create/

steps/

subchannel-members-list.react.js

81 lines

Diff 33375

View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

[web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branchingClosedPublicActions