Details

Reviewers

tomek
• jacek

Commits

rCOMM137af291c57d: [web] Remove usage of `setTab` and replace with `setCurrentTabType`

Summary

Remove setTab since it's no longer necessary and replace usages with setCurrentTabType which does the exact same thing.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.

Depends on D3763

Test Plan

Open ThreadSettingsModal
Switch between tabs as before

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 18 2022, 2:16 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 2:16 PM

Harbormaster completed remote builds in B8277: Diff 11573.Apr 18 2022, 2:22 PM

atul requested review of this revision.Apr 18 2022, 2:22 PM

atul added a child revision: D3765: [web] Move `onChangeName` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 18 2022, 2:34 PM

rebase

Harbormaster completed remote builds in B8335: Diff 11645.Apr 19 2022, 3:11 PM

tomek requested changes to this revision.Apr 21 2022, 3:01 AM

tomek added inline comments.

web/modals/threads/thread-settings-modal.react.js
449–451	Why do we need this method? Can't we just use `setCurrentTabType`?

This revision now requires changes to proceed.Apr 21 2022, 3:01 AM

atul requested review of this revision.Apr 21 2022, 9:07 AM

atul added inline comments.

web/modals/threads/thread-settings-modal.react.js
449–451	Ah yeah it's no longer necessary. It used to be a helper function that set the tab when the state was an object (bc class component), but now it's unnecessary. Will update this diff to just be about removing `setTab` and using `setCurrentTabType` in its place.

address feedback

atul retitled this revision from [web] Move `setTab` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal` to [web] Remove usage of `setTab` and replace with `setCurrentTabType`.Apr 21 2022, 9:54 AM

atul edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B8408: Diff 11733!Apr 21 2022, 9:58 AM

Harbormaster completed remote builds in B8408: Diff 11733.Apr 21 2022, 10:02 AM

rebase (sequence after the already landed diffs)

Harbormaster completed remote builds in B8478: Diff 11823.Apr 24 2022, 11:16 AM

atul added a child revision: D3821: [web] Temporarily remove refs in `ThreadSettingsModal` altogether.Apr 24 2022, 11:24 AM

atul removed a parent revision: D3763: [web] Move `changeQueued` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 24 2022, 1:58 PM

atul removed a child revision: D3765: [web] Move `onChangeName` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.

tomek accepted this revision.Apr 25 2022, 6:39 AM

This revision is now accepted and ready to land.Apr 25 2022, 6:39 AM