Page MenuHomePhabricator
Differential D3796

[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 7:04 PM
Unknown Object (File)
Tue, Apr 8, 6:33 PM
Unknown Object (File)
Tue, Apr 8, 6:16 PM
Unknown Object (File)
Tue, Apr 8, 5:29 PM
Unknown Object (File)
Tue, Apr 8, 3:32 PM
Unknown Object (File)
Mon, Mar 31, 6:59 PM
Unknown Object (File)
Mon, Mar 31, 5:08 PM
Unknown Object (File)
Mon, Mar 31, 5:01 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
Commits
rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to…
Summary

Move onSubmit out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)

Depends on D3795

Test Plan
  1. Open ThreadSettingsModal
  2. Mess with the settings
  3. Hit save and make sure things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
23 lines

Diff 11682

View Options

web/modals/threads/thread-settings-modal.react.js

Show All 18 Lines
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
class DatabaseManager : public DatabaseManagerBase { class DatabaseManager : public DatabaseManagerBase {
private:
template <class T>
T populatePutRequestFromMessageItem(T &putRequest, const MessageItem &item);
public: public:
static DatabaseManager &getInstance(); static DatabaseManager &getInstance();
bool isTableAvailable(const std::string &tableName); bool isTableAvailable(const std::string &tableName);
void putSessionItem(const DeviceSessionItem &item); void putSessionItem(const DeviceSessionItem &item);
std::shared_ptr<DeviceSessionItem> std::shared_ptr<DeviceSessionItem>
findSessionItem(const std::string &deviceID); findSessionItem(const std::string &deviceID);
void removeSessionItem(const std::string &sessionID); void removeSessionItem(const std::string &sessionID);
void putSessionSignItem(const SessionSignItem &item); void putSessionSignItem(const SessionSignItem &item);
std::shared_ptr<SessionSignItem> std::shared_ptr<SessionSignItem>
findSessionSignItem(const std::string &deviceID); findSessionSignItem(const std::string &deviceID);
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
void putMessageItemsByBatch(std::vector<MessageItem> &messageItems);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>> std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID); findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm