[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 3:21 PM.

Details

Reviewers

tomek
• jacek

Commits

rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to…

Summary

Move onSubmit out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component (any day now...)

Depends on D3795

Test Plan

Open ThreadSettingsModal
Mess with the settings
Hit save and make sure things continue to look/work as expected

Diff Detail

Repository

rCOMM Comm

Branch

actuallylandapril21 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 20 2022, 3:21 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 20 2022, 3:21 PM

Harbormaster completed remote builds in B8370: Diff 11682.Apr 20 2022, 3:26 PM

atul requested review of this revision.Apr 20 2022, 3:26 PM

atul added a child revision: D3797: [web] Move up `ComponentDid[Mount/Update]` functionality to `ConnectedThreadSettingsModal` `useEffect`.Apr 20 2022, 3:58 PM

tomek accepted this revision.Apr 21 2022, 8:50 AM

This revision is now accepted and ready to land.Apr 21 2022, 8:50 AM

rebase before landing

Harbormaster completed remote builds in B8475: Diff 11818.Apr 22 2022, 2:38 PM

Closed by commit rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 22 2022, 2:40 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4cc6a0bc5703: [web] Move `onSubmit` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.react.js

23 lines

Diff 11818

View Options

web/modals/threads/thread-settings-modal.react.js

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	function CommunityDrawer(): React.Node {
}, []);		}, []);

const communitiesComponents = drawerItemsData.map(item => (		const communitiesComponents = drawerItemsData.map(item => (
<CommunityDrawerItemCommunity		<CommunityDrawerItemCommunity
itemData={item}		itemData={item}
key={item.threadInfo.id}		key={item.threadInfo.id}
toggleExpanded={setOpenCommunityOrClose}		toggleExpanded={setOpenCommunityOrClose}
expanded={item.threadInfo.id === openCommunity}		expanded={item.threadInfo.id === openCommunity}
		paddingLeft={10}
/>		/>
));		));

return (		return (
<ThreadListProvider>		<ThreadListProvider>
<div className={css.container}>{communitiesComponents}</div>		<div className={css.container}>{communitiesComponents}</div>
</ThreadListProvider>		</ThreadListProvider>
);		);
}		}

export default CommunityDrawer;		export default CommunityDrawer;

[web] Move `onSubmit` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`ClosedPublicActions