Remove setTab since it's no longer necessary and replace usages with setCurrentTabType which does the exact same thing.
As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.
Depends on D3763
Details
Details
- Open ThreadSettingsModal
- Switch between tabs as before
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 449–451 ↗ | (On Diff #11645) | Why do we need this method? Can't we just use setCurrentTabType? |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 449–451 ↗ | (On Diff #11645) | Ah yeah it's no longer necessary. It used to be a helper function that set the tab when the state was an object (bc class component), but now it's unnecessary. Will update this diff to just be about removing setTab and using setCurrentTabType in its place. |