Page MenuHomePhabricator
Differential D3855

[keyserver] Bump `firebase-admin` to `10.1.0`
ClosedPublic
Actions

Authored by atul on Apr 27 2022, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 7:35 PM
Unknown Object (File)
Wed, Feb 26, 1:24 PM
Unknown Object (File)
Wed, Feb 26, 12:26 AM
Unknown Object (File)
Tue, Feb 25, 7:25 PM
Unknown Object (File)
Feb 8 2025, 10:59 AM
Unknown Object (File)
Feb 3 2025, 3:07 PM
Unknown Object (File)
Feb 2 2025, 1:43 AM
Unknown Object (File)
Feb 1 2025, 2:38 AM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
• jacek
tomek
ashoat
Commits
rCOMM9c862dfb76d7: [keyserver] Bump `firebase-admin` to `10.1.0`
Summary

Downstream dependencies have issues surfaced by yarn audit

Checked the 10.0.2 and 10.1.0 release notes and found no evidence of breaking changes: https://github.com/firebase/firebase-admin-node/releases

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Branch
landapr27 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 27 2022, 7:24 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptApr 27 2022, 7:24 AM
atul updated this revision to Diff 11985.Apr 27 2022, 7:28 AM

some more

Harbormaster completed remote builds in B8600: Diff 11984.Apr 27 2022, 7:29 AM
Harbormaster completed remote builds in B8601: Diff 11985.Apr 27 2022, 7:35 AM
atul requested review of this revision.Apr 27 2022, 7:35 AM
atul added a child revision: D3856: [native] Bump `react-native-svg` to `12.3.0`.Apr 27 2022, 8:17 AM
ashoat accepted this revision.Apr 27 2022, 2:29 PM
This revision is now accepted and ready to land.Apr 27 2022, 2:29 PM
ashoat added a comment.Apr 27 2022, 2:29 PM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

atul updated this revision to Diff 12010.Apr 27 2022, 2:31 PM

rebase before landing

Harbormaster completed remote builds in B8621: Diff 12010.Apr 27 2022, 2:35 PM
Closed by commit rCOMM9c862dfb76d7: [keyserver] Bump `firebase-admin` to `10.1.0` (authored by atul). · Explain WhyApr 27 2022, 2:44 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9c862dfb76d7: [keyserver] Bump `firebase-admin` to `10.1.0`.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines
390 lines

Diff 12010

View Options

keyserver/package.json

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { ChevronRight } from 'react-feather';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { threadIsPending } from 'lib/shared/thread-utils.js'; import { threadIsPending } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import { pinnedMessageCountText } from 'lib/utils/message-pinning-utils.js';
import PinnedMessagesBanner from './pinned-messages-banner.react.js';
import ThreadMenu from './thread-menu.react.js'; import ThreadMenu from './thread-menu.react.js';
import css from './thread-top-bar.css'; import css from './thread-top-bar.css';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
import Button from '../components/button.react.js'; import Button from '../components/button.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import PinnedMessagesModal from '../modals/chat/pinned-messages-modal.react.js';
import MessageSearchModal from '../modals/search/message-search-modal.react.js'; import MessageSearchModal from '../modals/search/message-search-modal.react.js';
type ThreadTopBarProps = { type ThreadTopBarProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadTopBar(props: ThreadTopBarProps): React.Node { function ThreadTopBar(props: ThreadTopBarProps): React.Node {
const { threadInfo } = props; const { threadInfo } = props;
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
let threadMenu = null; let threadMenu = null;
if (!threadIsPending(threadInfo.id)) { if (!threadIsPending(threadInfo.id)) {
threadMenu = <ThreadMenu threadInfo={threadInfo} />; threadMenu = <ThreadMenu threadInfo={threadInfo} />;
} }
const bannerText =
!!threadInfo.pinnedCount && pinnedMessageCountText(threadInfo.pinnedCount);
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const pushThreadPinsModal = React.useCallback(() => {
pushModal(
<InputStateContext.Provider value={inputState}>
<PinnedMessagesModal threadInfo={threadInfo} />
</InputStateContext.Provider>,
);
}, [pushModal, inputState, threadInfo]);
const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) {
return null;
}
return (
<div className={css.pinnedCountBanner}>
<a className={css.pinnedCountText} onClick={pushThreadPinsModal}>
{bannerText}
<ChevronRight size={14} className={css.chevronRight} />
</a>
</div>
);
}, [bannerText, pushThreadPinsModal]);
const onClickSearch = React.useCallback( const onClickSearch = React.useCallback(
() => () =>
pushModal( pushModal(
<InputStateContext.Provider value={inputState}> <InputStateContext.Provider value={inputState}>
<MessageSearchModal threadInfo={threadInfo} /> <MessageSearchModal threadInfo={threadInfo} />
</InputStateContext.Provider>, </InputStateContext.Provider>,
), ),
Show All 15 Lines <>
size={24} size={24}
icon="search" icon="search"
className={css.searchButtonIcon} className={css.searchButtonIcon}
/> />
</Button> </Button>
{threadMenu} {threadMenu}
</div> </div>
</div> </div>
{pinnedCountBanner} <PinnedMessagesBanner threadInfo={threadInfo} />
</> </>
); );
} }
export default ThreadTopBar; export default ThreadTopBar;
View Options

yarn.lock

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { ChevronRight } from 'react-feather';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { threadIsPending } from 'lib/shared/thread-utils.js'; import { threadIsPending } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import { pinnedMessageCountText } from 'lib/utils/message-pinning-utils.js';
import PinnedMessagesBanner from './pinned-messages-banner.react.js';
import ThreadMenu from './thread-menu.react.js'; import ThreadMenu from './thread-menu.react.js';
import css from './thread-top-bar.css'; import css from './thread-top-bar.css';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
import Button from '../components/button.react.js'; import Button from '../components/button.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import PinnedMessagesModal from '../modals/chat/pinned-messages-modal.react.js';
import MessageSearchModal from '../modals/search/message-search-modal.react.js'; import MessageSearchModal from '../modals/search/message-search-modal.react.js';
type ThreadTopBarProps = { type ThreadTopBarProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadTopBar(props: ThreadTopBarProps): React.Node { function ThreadTopBar(props: ThreadTopBarProps): React.Node {
const { threadInfo } = props; const { threadInfo } = props;
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
let threadMenu = null; let threadMenu = null;
if (!threadIsPending(threadInfo.id)) { if (!threadIsPending(threadInfo.id)) {
threadMenu = <ThreadMenu threadInfo={threadInfo} />; threadMenu = <ThreadMenu threadInfo={threadInfo} />;
} }
const bannerText =
!!threadInfo.pinnedCount && pinnedMessageCountText(threadInfo.pinnedCount);
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const pushThreadPinsModal = React.useCallback(() => {
pushModal(
<InputStateContext.Provider value={inputState}>
<PinnedMessagesModal threadInfo={threadInfo} />
</InputStateContext.Provider>,
);
}, [pushModal, inputState, threadInfo]);
const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) {
return null;
}
return (
<div className={css.pinnedCountBanner}>
<a className={css.pinnedCountText} onClick={pushThreadPinsModal}>
{bannerText}
<ChevronRight size={14} className={css.chevronRight} />
</a>
</div>
);
}, [bannerText, pushThreadPinsModal]);
const onClickSearch = React.useCallback( const onClickSearch = React.useCallback(
() => () =>
pushModal( pushModal(
<InputStateContext.Provider value={inputState}> <InputStateContext.Provider value={inputState}>
<MessageSearchModal threadInfo={threadInfo} /> <MessageSearchModal threadInfo={threadInfo} />
</InputStateContext.Provider>, </InputStateContext.Provider>,
), ),
Show All 15 Lines <>
size={24} size={24}
icon="search" icon="search"
className={css.searchButtonIcon} className={css.searchButtonIcon}
/> />
</Button> </Button>
{threadMenu} {threadMenu}
</div> </div>
</div> </div>
{pinnedCountBanner} <PinnedMessagesBanner threadInfo={threadInfo} />
</> </>
); );
} }
export default ThreadTopBar; export default ThreadTopBar;