[web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab` component
ClosedPublic
Actions

Authored by atul on Apr 24 2022, 2:16 PM.

Details

Reviewers

• jacek
tomek

Commits

rCOMMf57c68e54724: [web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab`…

Summary

Push onChangeThreadType callback down to ThreadSettingsPrivacyTab component to clean up parent ThreadSettingsModal component and to move callback closer to where it's used.

Added threadInfo, queuedChanges, and setQueuedChanges props to ThreadSettingsPrivacyTab component so callback could be "constructed" from "within" the child component
Adding those props also lets us determine possiblyChangedThreadType within child component instead of having to pass in from parent

Depends on D3827

Test Plan

Open ThreadSettingsModal
Make sure that the "Privacy" tab continues to look/work as expected

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D3828 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 24 2022, 2:16 PM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 24 2022, 2:17 PM

atul published this revision for review.Apr 24 2022, 2:17 PM

Harbormaster completed remote builds in B8489: Diff 11834.Apr 24 2022, 2:22 PM

atul added a child revision: D3832: [web] Add `nameInputRef` back to `ThreadSettingsGeneralTab`.Apr 25 2022, 6:16 AM

tomek accepted this revision.Apr 26 2022, 8:28 AM

tomek added inline comments.

web/modals/threads/thread-settings-privacy-tab.react.js
32 ↗	(On Diff #11834)	We can use a callback here
54 ↗	(On Diff #11834)	I think it might be a good idea to create a variable `queuedChanges.type ?? threadInfo.type` and use it in both places

This revision is now accepted and ready to land.Apr 26 2022, 8:28 AM

rebase

Harbormaster completed remote builds in B8569: Diff 11948.Apr 26 2022, 10:40 AM

atul added inline comments.Apr 28 2022, 1:47 PM

web/modals/threads/thread-settings-privacy-tab.react.js
32 ↗	(On Diff #11834)	https://linear.app/comm/issue/ENG-1061/[web]-use-callback-version-of-setstate-in-threadsettingsmodal
54 ↗	(On Diff #11834)	will bring back the `potentiallyChangedValue` helper function to cut the verbosity here