Page MenuHomePhabricator
Differential D3828

[web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab` component
ClosedPublic
Actions

Authored by atul on Apr 24 2022, 2:16 PM.
Tags
None
Referenced Files
F3175241: D3828.id11948.diff
Thu, Nov 7, 7:39 PM
F3175134: D3828.id12078.diff
Thu, Nov 7, 7:35 PM
F3174631: D3828.diff
Thu, Nov 7, 5:27 PM
Unknown Object (File)
Tue, Nov 5, 4:56 AM
Unknown Object (File)
Thu, Oct 10, 2:32 AM
Unknown Object (File)
Thu, Oct 10, 2:32 AM
Unknown Object (File)
Thu, Oct 10, 2:31 AM
Unknown Object (File)
Thu, Oct 10, 2:31 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMMf57c68e54724: [web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab`…
Summary

Push onChangeThreadType callback down to ThreadSettingsPrivacyTab component to clean up parent ThreadSettingsModal component and to move callback closer to where it's used.

  • Added threadInfo, queuedChanges, and setQueuedChanges props to ThreadSettingsPrivacyTab component so callback could be "constructed" from "within" the child component
  • Adding those props also lets us determine possiblyChangedThreadType within child component instead of having to pass in from parent

Depends on D3827

Test Plan
  1. Open ThreadSettingsModal
  2. Make sure that the "Privacy" tab continues to look/work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 24 2022, 2:16 PM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 24 2022, 2:17 PM
atul published this revision for review.Apr 24 2022, 2:17 PM
Harbormaster completed remote builds in B8489: Diff 11834.Apr 24 2022, 2:22 PM
atul added a child revision: D3832: [web] Add `nameInputRef` back to `ThreadSettingsGeneralTab`.Apr 25 2022, 6:16 AM
tomek accepted this revision.Apr 26 2022, 8:28 AM
tomek added inline comments.
web/modals/threads/thread-settings-privacy-tab.react.js
32 ↗(On Diff #11834)

We can use a callback here

54 ↗(On Diff #11834)

I think it might be a good idea to create a variable queuedChanges.type ?? threadInfo.type and use it in both places

This revision is now accepted and ready to land.Apr 26 2022, 8:28 AM
atul updated this revision to Diff 11948.Apr 26 2022, 10:33 AM

rebase

Harbormaster completed remote builds in B8569: Diff 11948.Apr 26 2022, 10:40 AM
atul added inline comments.Apr 28 2022, 1:47 PM
web/modals/threads/thread-settings-privacy-tab.react.js
32 ↗(On Diff #11834)

https://linear.app/comm/issue/ENG-1061/[web]-use-callback-version-of-setstate-in-threadsettingsmodal

54 ↗(On Diff #11834)

will bring back the potentiallyChangedValue helper function to cut the verbosity here

atul updated this revision to Diff 12077.Apr 28 2022, 1:50 PM

rebase before landing

Harbormaster completed remote builds in B8674: Diff 12077.Apr 28 2022, 1:54 PM
Closed by commit rCOMMf57c68e54724: [web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab`… (authored by atul). · Explain WhyApr 28 2022, 2:01 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMf57c68e54724: [web] Push `onChangeThreadType` callback down to `ThreadSettingsPrivacyTab`….

Revision Contents
Changeset List

Diff 12078

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/thread-settings-privacy-tab.react.js

Loading...