Allow for the creation of a local MySQL instance by just running a unprivileged command.
Will do something similar for mac+launchd soon.
Depends on D3874
Details
Details
- Reviewers
ashoat varun - Commits
- rCOMMebb277e365a6: Add command to start MySQL on linux
nix run .#mysql-up to bring up the server
journalctl -f --user-unit comm-mysql to view mysql logs
nix run .#mysql-down to bring the server down
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Interesting... I'm surprised these utilities don't exist upstream anywhere, since it feels like anybody with a dev environment that relies on MySQL will need them
| nix/mysql-down-linux.nix | ||
|---|---|---|
| 5–7 | Thanks for this comment, it's really helpful! | |
| nix/mysql-up-linux.nix | ||
| 20 | Are you intentionally using the port 3006 rather than the default 3306? (Assuming yes, but figured I'd check) | |
| 34 | I assume we're using bash-specific syntax below... does this need to be made explicit anyways? | |
| 42 | I think it's preferable to use [[ ]] over [ ] | |
Comment Actions
Interesting... I'm surprised these utilities don't exist upstream anywhere, since it feels like anybody with a dev environment that relies on MySQL will need them
They exist at the NixOS (e.g. machine/system) level, but they don't within Nixpkgs.
| nix/mysql-up-linux.nix | ||
|---|---|---|
| 20 | This I probably fat fingered, to be honest. I tested it using mysql but that uses the UNIX socket by default. | |
| nix/mysql-up-linux.nix | ||
|---|---|---|
| 20 ↗ | (On Diff #12336) | Is --port 3306 even necessary since it's the default? (I don't feel strongly about this... happy to keep it here if you want to be explicit) |
| 42 ↗ | (On Diff #12336) | Any reason we're not using [[ ]] here? (When somebody asks for changes on one line, you should always search for other cases of the same thing and apply the feedback everywhere) |
| 67 ↗ | (On Diff #12336) | I was confused about this use of the double-single-quotes. I did some research and looks like it's a way of escaping the $ character. In case it's interesting to other reviewers, more details here |
| 73 ↗ | (On Diff #12336) | Can we also run cd keyserver && yarn dist/scripts/create-db.js here to set up the tables? (To do this we would need to save the DB credentials to keyserver/secrets/db_config.json, and would otherwise need the repo to be initialized with yarn cleaninstall && cd keyserver && yarn prod-build) |
| nix/mysql-up-linux.nix | ||
|---|---|---|
| 42 ↗ | (On Diff #12336) | looks like I missed this one, got the other 3 |
| 67 ↗ | (On Diff #12336) | Correct, if I want to fully escape a $ in a "lines" block, then I need to use ''$ to do so. Although, in this case, it's kind of a noop, as nix only changes the behavior when you use the ${...} interpolation syntax. |
| 73 ↗ | (On Diff #12336) | right now I'm just using the insecure initialization since it's a dev environment, which means user: root; pass: "". But I can run anything if needed, just transcribed what was in the dev env doc. |
Comment Actions
Before landing, can you create a Linear task for the MySQL initialization?
Some tips for the task creation:
- See "Guidelines for new Linear issues" here
- Probably should be a child of ENG-177
- Should be within the "Nix environment" project
Some stuff you might want to put in there:
- Secure initialization (what you talked about)
- Creation of MySQL user / database
- Population of keyserver/secrets/db_config.json config file
- Creation of tables by running yarn cleaninstall && cd keyserver && yarn prod-build && yarn script dist/scripts/create-db.js
Comment Actions
This should not have been landed without addressing my comment!! I left an explicit comment saying "Before landing, can you create a Linear task for the MySQL initialization?"
This calls into question if we can trust @jonringer-comm with an "accept with comments". @jonringer-comm, please keep this in mind going forward. Just because a diff is accepted, does NOT mean you can just land it. You ALWAYS need to check the comments and address any final requests BEFORE landing.
@varun, given @jonringer-comm is out for his honeymoon, can you handle the task creation detailed above?